Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces WinUI (Windows App SDK) runtime test execution in CI by packaging/installing the SamplesApp and launching it via an app execution alias, while excluding a large set of currently failing runtime tests on RuntimeTestPlatforms.NativeWinUI to stabilize the new lane.
Changes:
- Add an Azure DevOps WinUI Runtime Tests job (matrix-split) plus a PowerShell runner script that launches the packaged app via execution alias and collects NUnit results.
- Update SamplesApp Windows packaging (manifest execution alias, signing/build settings) to support CI installation and CLI launching.
- Exclude many runtime tests from
NativeWinUI, and adjust a few test/runtime utilities used by the test harness.
Reviewed changes
Copilot reviewed 132 out of 132 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Uno.UI.Tests/Windows_Globalization/Given_NumeralSystemTranslator.cs | Adjust DataRow conditional compilation for WinAppSDK differences. |
| src/Uno.UI.Tests/Windows_Globalization/Given_CurrencyFormatter.cs | Exclude specific currency formatter tests from NativeWinUI (runtime UI tests). |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Shapes/Given_Rectangle.cs | Exclude a measurement test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Shapes/Given_Path.cs | Exclude multiple Path/Geometry-related tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Media_Imaging/Given_RenderTargetBitmap.cs | Exclude RenderTargetBitmap pixel test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Media_Imaging/Given_BitmapSource.cs | Exclude BitmapSource tests from NativeWinUI and expand exclusions for a disposal test. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Media_Animation/Given_TemplateBindingAfterAnimation.cs | Exclude animation/template binding tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Media_Animation/Given_DoubleAnimation.cs | Exclude a combinatorial animation test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Media_Animation/Given_ColorAnimationUsingKeyFrames.cs | Exclude theme-change animation tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Media/Given_VisualTreeHelper.cs | Exclude popup uniqueness tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Media/Given_BasicAutomatedTransformation.cs | Exclude multiple image-based transformation tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Input/Given_FocusManager.cs | Exclude several focus/navigation tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Documents/Given_Hyperlink.cs | Exclude hyperlink visual-state tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Data/Given_BindableNullableValueType.cs | Exclude nullable binding UI test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls_Primitives/Given_LayoutInformation.cs | Exclude LayoutInformation class from NativeWinUI (cleanup failing). |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/UniformGridLayout/Given_UniformGridLayout.cs | Exclude UniformGridLayout test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater.cs | Exclude ItemsRepeater test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Icons/Given_IconSourceElement.cs | Exclude icon switching test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_UIElementCollection.cs | Exclude invalid move test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TwoPaneView.cs | Exclude template apply test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TreeView.cs | Exclude TreeView test class from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ToolTip.cs | Exclude theme switch tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ToggleSwitch.cs | Exclude knob translation test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TimePicker.cs | Exclude TimePicker test class and a specific work-item test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBox.cs | Exclude multiple TextBox interaction/layout tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs | Exclude TextBlock font/wrapping tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Slider.cs | Exclude Slider tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ScrollViewer.cs | Exclude ScrollViewer resize/ChangeView tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_RadioButton.cs | Exclude GroupName null test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ProgressRing.cs | Exclude ProgressRing visibility test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Pivot.cs | Exclude Pivot single-item visibility test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_PersonPicture.cs | Exclude PersonPicture initials test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_NavigationView.cs | Exclude NavigationView vector-changed test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_MenuFlyout.cs | Exclude a popup test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ListViewBase_Items.cs | Exclude ListViewBase_Items class from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ListViewBase.cs | Exclude many ListViewBase tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ListViewBase.Measure.cs | Exclude measurement tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ItemsPresenter.cs | Exclude ItemsPresenter tests (class + specific methods) from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Image.cs | Exclude multiple Image/BitmapImage tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_GridLayouting.cs | Exclude many Grid layouting assertions from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Grid.cs | Exclude Grid spacing and runtime layout mutation tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_FrameworkTemplatePool.cs | Exclude TemplatePooling TextBox test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Frame.cs | Exclude Frame test class from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Flyout.cs | Expand exclusions and exclude several Flyout tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_FlipView.cs | Exclude multiple FlipView tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_DataTemplateSelector.cs | Exclude DataTemplateSelector null-container tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ContentPresenter.cs | Exclude multiple ContentPresenter tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ContentDialog.cs | Exclude several ContentDialog tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_CommandBar.cs | Exclude CommandBar alignment test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ComboBox.cs | Exclude multiple ComboBox interaction tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Button.cs | Exclude delayed-command enabled-state test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_AutoSuggestBox.cs | Exclude a full-window AutoSuggestBox test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_AppBarButton.cs | Expand exclusions to include NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/DatePickerIntegrationTests.cs | Exclude DatePicker integration tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_XamlRoot.cs | Exclude XamlRoot window-root matching test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_Window.cs | Ensure windows are closed in finally; exclude one window test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_VisualStateManager.cs | Exclude selector visual state tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_UIElement.cs | Exclude injected-pointer translation hit-test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_UIElement.TransformToVisual.cs | Exclude multiple TransformToVisual tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_ThemeResource.cs | Exclude theme resource tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_Style.cs | Exclude style application failure test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_Panel.cs | Exclude custom measure/arrange test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_ThemeResources.cs | Exclude theme-change tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_Layouting.cs | Exclude IsEnabled-null test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_EffectiveViewport.cs | Exclude effective viewport data-row test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs | Expand exclusions to include NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement.cs | Exclude multiple layout/measure/loaded/unloaded tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_DispatcherTimer.cs | Exclude exception-in-tick test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_DependencyProperty.cs | Exclude dependency property behavior tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_DependencyObjectCollection.cs | Exclude collection indexer/add tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_Control.cs | Exclude multiple Control/style-related tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_StartScreen/Given_JumpListItem.cs | Exclude JumpListItem tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Popups/Given_MessageDialog.cs | Exclude MessageDialog tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Composition/Given_InteractionTracker.cs | Exclude interaction tracker test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Composition/Given_ExpressionAnimation.cs | Exclude multiple composition animation tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_System/Given_DispatcherQueueTimer.cs | Exclude DispatcherQueueTimer tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_System/Given_DispatcherQueue.cs | Exclude dispatcher scheduling test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Storage/Streams/Given_WindowsRuntimeStreamExtensions.cs | Exclude stream extension tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Storage/Streams/Given_RandomAccessStreamReference.cs | Exclude RandomAccessStreamReference test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Storage/Streams/Given_DataReader.cs | Exclude DataReader null-buffer test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Storage/Streams/Given_Buffer.cs | Exclude Buffer boundary tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Storage/Given_StorageFolder_GetItems.cs | Exclude StorageFolder GetItems class from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Storage/Given_StorageFolder.cs | Exclude StorageFolder creation tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Storage/Given_StorageFile_Native.base.cs | Exclude InputStreamFlush test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Storage/Given_StorageFile2.cs | Exclude DateCreated test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Storage/Given_StorageFile.cs | Exclude multiple StorageFile stream tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Graphics_Imaging/Given_BitmapEncoder.cs | Add missing infra using; exclude encoder create test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Globalization/Given_DateTimeFormatter.cs | Exclude globalization formatter tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Globalization/Given_Calendar.cs | Exclude Julian calendar crash-regression test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Globalization/Given_ApplicationLanguages.cs | Exclude language override tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Foundation/Metadata/Given_ApiInformation.cs | Exclude API information caching test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_Data/Pdf/Given_PdfDocument.cs | Exclude PdfDocument tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_ApplicationModel_Resources/Given_ResourceLoader.cs | Exclude multiple ResourceLoader localization tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_ApplicationModel/Email/Given_EmailRecipient.cs | Exclude EmailRecipient null-handling tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_ApplicationModel/Email/Given_EmailMessage.cs | Exclude EmailMessage null-handling tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Windows_ApplicationModel/Email/Given_EmailManager.cs | Exclude EmailManager null argument test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Uno_UI_Toolkit/Given_VisibleBoundsPadding.cs | Exclude VisibleBoundsPadding test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Uno_UI/Given_ResourceResolver.cs | Exclude native-views resource resolution test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/TemplatedParent/TemplatedParentTests.cs | Exclude multiple templated-parent regression tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_TreeView.cs | Exclude MUX TreeView test class from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_TabView.cs | Expand exclusions to include NativeWinUI and exclude another test. |
| src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_NavigationView.cs | Exclude NavigationView theme/backbutton tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Windowing/Given_AppWindow.cs | Expand exclusions to include NativeWinUI. |
| src/Uno.UI.RuntimeTests/Tests/BindingTests/BindingTests.cs | Exclude several theme-resource binding tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/MUX/Windows_UI_Xaml_Controls/SwipeControl/SwipeControl_APITests.cs | Exclude SwipeControl API tests from NativeWinUI (cleanup failing). |
| src/Uno.UI.RuntimeTests/MUX/Utilities/RunOnUIThread.cs | Switch to DispatcherQueue-based execution for WinUI and add new overloads. |
| src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/TimePicker/TimePickerIntegrationTests.cs | Exclude TimePicker integration tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/IntegrationTests/dxaml/controls/stackpanel/StackPanelIntegrationTests.cs | Exclude StackPanel integration test from NativeWinUI. |
| src/Uno.UI.RuntimeTests/IntegrationTests/dxaml/controls/grid/GridIntegrationTests.cs | Exclude multiple Grid integration tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/IntegrationTests/dxaml/controls/frame/FrameIntegrationTests.cs | Exclude Frame integration tests from NativeWinUI; wait for frame loaded after setup. |
| src/Uno.UI.RuntimeTests/IntegrationTests/dxaml/controls/calendarview/CalendarViewIntegrationTests.cs | Exclude CalendarView integration tests from NativeWinUI. |
| src/Uno.UI.RuntimeTests/IntegrationTests/common/TestServices.cs | Propagate UI-thread exceptions back to callers. |
| src/Uno.CrossTargetting.targets | Adjust Windows WinUI constants (remove HAS_INPUT_INJECTOR for this TFM). |
| src/SamplesApp/SamplesApp.Windows/SamplesApp.Windows.csproj | Add MSIX packaging/signing properties and Windows SDK build tools reference. |
| src/SamplesApp/SamplesApp.Windows/Package.appxmanifest | Add app execution alias extension and namespaces. |
| src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UnitTest/UnitTestsControl.cs | Improve non-Uno logging to Console/Debug. |
| src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Styles/SampleControl.xaml | Switch merged dictionary sources to ms-appx URIs; formatting cleanup. |
| src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Styles/Controls/_Controls.xaml | Switch merged dictionary sources to ms-appx URIs; formatting cleanup. |
| src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Styles/Controls/ToggleButton.xaml | Switch merged dictionary source to ms-appx URI; formatting cleanup. |
| src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Styles/Controls/TextBox.xaml | Switch merged dictionary source to ms-appx URI; formatting cleanup and VSM reorder. |
| src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Styles/Controls/TextBlock.xaml | Switch merged dictionary source to ms-appx URI; formatting cleanup. |
| src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Styles/Controls/RadioButton.xaml | Switch merged dictionary source to ms-appx URI; formatting/VSM reorder. |
| src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Styles/Controls/ListViewItem.xaml | Switch merged dictionary source to ms-appx URI; formatting/VSM reorder. |
| src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Styles/Controls/Button.xaml | Switch merged dictionary source to ms-appx URI; formatting/VSM reorder. |
| src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Styles/Application/_Application.xaml | Switch merged dictionary sources to ms-appx URIs; formatting cleanup. |
| src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Controls/SampleChooserControl.xaml | Switch merged dictionary sources to ms-appx URIs; reformat KeyboardAccelerators. |
| src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs | Use visual-tree name lookup for locating UnitTests root control. |
| src/SamplesApp/SamplesApp.Shared/App.xaml.cs | Add WinUI unhandled exception logging and WinUI-specific command-line argument handling. |
| doc/articles/uno-development/creating-runtime-tests.md | Document PlatformCondition usage and available platforms. |
| build/test-scripts/run-winui-runtime-tests.ps1 | Add WinUI runtime test runner script using app execution alias + NUnit transform tooling. |
| build/ci/tests/.azure-devops-tests-winappsdk.yml | Add MSIX signing setup and a WinUI Runtime Tests job (matrix-split) to WinAppSDK CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22707/wasm-skia-net9/index.html |
|
|
f1a19d1 to
eb4a962
Compare
eb4a962 to
28a7962
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 132 out of 132 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22707/wasm-skia-net9/index.html |
|
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 138 out of 138 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UnitTest/UnitTestsControl.xaml
Outdated
Show resolved
Hide resolved
20951d1 to
e6c8e6a
Compare
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22707/wasm-skia-net9/index.html |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 137 out of 137 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...mplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs
Show resolved
Hide resolved
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22707/wasm-skia-net9/index.html |
|
|
Co-authored-by: MartinZikmund <1075116+MartinZikmund@users.noreply.github.com>
Co-authored-by: MartinZikmund <1075116+MartinZikmund@users.noreply.github.com>
7f8b3ec to
76471a0
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 140 out of 140 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (2)
build/ci/tests/.azure-devops-tests-winappsdk.yml:12
- The build job pool is configured as
vmImage: ${{ parameters.poolName }}, butpoolNameis a new parameter andvmImageis now unused. If callers still passvmImage, this job may run with an empty/invalid image. Either use${{ parameters.vmImage }}forvmImage:or makepoolName/vmImagesemantics consistent and update the template call sites accordingly.
parameters:
vmImage: ''
poolName: ''
jobs:
- job: WASDK_Build
displayName: 'Build Samples App'
cancelTimeoutInMinutes: 0
pool:
vmImage: ${{ parameters.poolName }}
src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UnitTest/UnitTestsControl.cs:909
- Typo in comment: "developpers" should be "developers".
{
await TestServices.WindowHelper.RootElementDispatcher.RunAsync(() =>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22707/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22707/docs/index.html |
1 similar comment
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22707/docs/index.html |
Removed conditional debug logging from UnitTestsControl.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 140 out of 140 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22707/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22707/docs/index.html |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 140 out of 140 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22707/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22707/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22707/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22707/docs/index.html |
GitHub Issue: closes #4612
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️