fix: trackpad ios ipad desktop by ajpinedam · Pull Request #22762 · unoplatform/uno

ajpinedam · 2026-03-02T21:53:13Z

GitHub Issue: closes https://github.com/unoplatform/uno-private/issues/1740

PR Type:

🐞 Bugfix

What is the current behavior? 🤔

What is the new behavior? 🚀

PR Checklist ✅

Please check if your PR fulfills the following requirements:

📝 Commits must be following the Conventional Commits specification.
🧪 Added Runtime tests, UI tests, or a manual test sample for the changes have been added (for bug fixes / features) (if applicable)
📚 Docs have been added/updated which fit documentation template (for bug fixes / features)
🖼️ Validated PR Screenshots Compare Test Run results.
❗ Contains NO breaking changes

Other information ℹ️

Copilot

Pull request overview

This PR adjusts trackpad/mouse-wheel scrolling behavior for Apple platforms (iOS/iPadOS + Mac Catalyst) to improve responsiveness and correctness when scroll events arrive at high frequency.

Changes:

Modify ScrollContentPresenter wheel scrolling on iOS to avoid long composition animations by applying immediate offset updates.
Add Mac Catalyst scroll-event forwarding from UIWindow.SendEvent into the pointer input pipeline, and update iOS scroll gesture handling to support inertia via CADisplayLink.
Ensure Uno.UI.Dispatching.netcoremobile selects the Skia dispatcher implementation when building with a “generic” netX.Y target framework override.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.cs	Adjusts wheel-scroll offset updates (special-cases iOS) to avoid animation backlog with trackpads.
src/Uno.UI.Runtime.Skia.AppleUIKit/UI/Xaml/Window/AppleUIKitWindow.cs	Hooks Mac Catalyst scroll UIEvents and forwards deltas into Uno’s pointer input source.
src/Uno.UI.Runtime.Skia.AppleUIKit/Devices/Input/TopViewLayer.cs	Tightens iOS scroll gesture recognizer configuration and routes gesture handling through the updated API.
src/Uno.UI.Runtime.Skia.AppleUIKit/Devices/Input/AppleUIKitPointerInputSource.cs	Adds iOS inertia scrolling and Mac Catalyst scroll event handling, generating wheel-like pointer events.
src/Uno.UI.Dispatching/Uno.UI.Dispatching.netcoremobile.csproj	Sets `UnoRuntimeIdentifier` to `Skia` for “generic net” builds so the Skia dispatcher source is included.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.cs

src/Uno.UI.Runtime.Skia.AppleUIKit/Devices/Input/AppleUIKitPointerInputSource.cs

unodevops · 2026-03-03T00:46:29Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22762/wasm-skia-net9/index.html

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.cs

src/Uno.UI.Runtime.Skia.AppleUIKit/Devices/Input/AppleUIKitPointerInputSource.cs

src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.cs

unodevops · 2026-03-03T02:34:28Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22762/wasm-skia-net9/index.html

unodevops · 2026-03-03T04:24:15Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22762/wasm-skia-net9/index.html

unodevops · 2026-03-03T05:10:44Z

⚠️⚠️ The build 199346 has failed on Uno.UI - CI.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Uno.UI.Runtime.Skia.AppleUIKit/Devices/Input/TopViewLayer.cs

src/Uno.UI.Runtime.Skia.AppleUIKit/Devices/Input/AppleUIKitPointerInputSource.cs

src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.cs

spouliot

most of copilot comments sounds legit (they might not be but they do sound like)

unodevops · 2026-03-03T15:17:14Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22762/wasm-skia-net9/index.html

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.cs

src/Uno.UI.Runtime.Skia.AppleUIKit/Devices/Input/AppleUIKitPointerInputSource.cs

unodevops · 2026-03-03T16:05:33Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22762/wasm-skia-net9/index.html

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Uno.UI.Runtime.Skia.AppleUIKit/Devices/Input/TopViewLayer.cs

unodevops · 2026-03-03T16:46:05Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22762/wasm-skia-net9/index.html

unodevops · 2026-03-03T19:06:44Z

⚠️⚠️ The build 199473 has failed on Uno.UI - CI.

unodevops · 2026-03-03T21:41:57Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22762/wasm-skia-net9/index.html

src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ScrollViewer.cs

ajpinedam self-assigned this Mar 2, 2026

Copilot AI review requested due to automatic review settings March 2, 2026 21:53

github-actions bot added platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform area/skia ✏️ Categorizes an issue or PR as relevant to Skia labels Mar 2, 2026

Copilot started reviewing on behalf of ajpinedam March 2, 2026 21:53 View session

ajpinedam requested review from Copilot, dr1rrb and ramezgerges and removed request for Copilot March 2, 2026 21:57

Copilot started reviewing on behalf of ajpinedam March 2, 2026 21:57 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 3, 2026 02:14

Copilot started reviewing on behalf of ajpinedam March 3, 2026 02:15 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

ajpinedam added 9 commits March 3, 2026 09:44

chore: fix project

3bff727

chore: wip implemenation

3cccdf1

chore: adjust iOS scrolling

e471144

chore: change recognizer subscriptiion

5d03b2c

chore: remove maccatalyst and add comments

4fad380

chore: allow all scroll type masks

eb95ec4

chore: remove maccatalyst implementation

192636d

chore: fix white spaces

29e7fc3

chore: fix ci

c06ab14

ajpinedam force-pushed the fix/trackpad.ios.ipad.desktop branch from 2437a5b to c06ab14 Compare March 3, 2026 14:55

Copilot AI review requested due to automatic review settings March 3, 2026 14:55

Copilot started reviewing on behalf of ajpinedam March 3, 2026 14:56 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

spouliot approved these changes Mar 3, 2026

View reviewed changes

chore: accept pr review suggestion (copilot)

f2b04d7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 3, 2026 15:40

ajpinedam and others added 2 commits March 3, 2026 10:40

chore: accept pr review suggestion (copilot)

9113127

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

chore: accept pr review suggestion (copilot)

ad4c728

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of ajpinedam March 3, 2026 15:40 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.cs Outdated Show resolved Hide resolved

src/Uno.UI.Runtime.Skia.AppleUIKit/Devices/Input/AppleUIKitPointerInputSource.cs Outdated Show resolved Hide resolved

chore: accept pr review suggestion (copilot)

f8aa350

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 3, 2026 16:07

chore: accept pr review suggestion (copilot)

1eef882

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of ajpinedam March 3, 2026 16:07 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

src/Uno.UI.Runtime.Skia.AppleUIKit/Devices/Input/TopViewLayer.cs Show resolved Hide resolved

test: adjust test for new logic

284654b

spouliot approved these changes Mar 3, 2026

View reviewed changes

MartinZikmund reviewed Mar 3, 2026

View reviewed changes

src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ScrollViewer.cs Show resolved Hide resolved

ajpinedam merged commit 5494e4d into unoplatform:master Mar 4, 2026
40 checks passed

Conversation

ajpinedam commented Mar 2, 2026

PR Type:

What is the current behavior? 🤔

What is the new behavior? 🚀

PR Checklist ✅

Other information ℹ️

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

unodevops commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

unodevops commented Mar 3, 2026

Uh oh!

unodevops commented Mar 3, 2026

Uh oh!

unodevops commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spouliot left a comment

Choose a reason for hiding this comment

Uh oh!

unodevops commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

unodevops commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

unodevops commented Mar 3, 2026

Uh oh!

unodevops commented Mar 3, 2026

Uh oh!

unodevops commented Mar 3, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants