Skip to content

Update CommandList.vue to adjust max-width#1676

Open
mwargan wants to merge 4 commits intounovue:devfrom
mwargan:patch-2
Open

Update CommandList.vue to adjust max-width#1676
mwargan wants to merge 4 commits intounovue:devfrom
mwargan:patch-2

Conversation

@mwargan
Copy link
Contributor

@mwargan mwargan commented Feb 7, 2026

🔗 Linked issue

#1675

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📸 Screenshots (if appropriate)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Summary by CodeRabbit

  • Bug Fixes
    • Improved max-width handling for list boxes to prevent overflow and ensure consistent layout.
    • Fixed dropdown submenu width so content no longer exceeds available space.
    • Constrained popover width for more predictable, stable display across viewports and device sizes.

@coderabbitai
Copy link

coderabbitai bot commented Feb 7, 2026

📝 Walkthrough

Walkthrough

Added a Tailwind-like max-width utility (max-w-(--reka-popper-available-width)) to class lists for three UI components, changing only rendered max-width styling without modifying logic, events, or public signatures. (49 words)

Changes

Cohort / File(s) Summary
UI max-width additions
apps/v4/registry/new-york-v4/ui/command/CommandList.vue, apps/v4/registry/new-york-v4/ui/dropdown-menu/DropdownMenuSubContent.vue, apps/v4/registry/new-york-v4/ui/popover/PopoverContent.vue
Appended max-w-(--reka-popper-available-width) to existing Tailwind-like class lists for dropdown/popover/Listbox content to constrain width to the popper available width. No changes to behavior, events, or public APIs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nudged a class to hug the space,
A tiny hop to find its place,
Popper's room now neatly known,
A quiet change — layout grown. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions only CommandList.vue, but the changeset modifies three files: CommandList.vue, DropdownMenuSubContent.vue, and PopoverContent.vue. The title does not reflect that max-width adjustments were made to multiple components. Update the title to reflect all changes, such as: 'Add max-width constraint to dropdown and popover components' or 'Apply max-width adjustment to CommandList, DropdownMenuSubContent, and PopoverContent'
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mwargan mwargan mentioned this pull request Feb 7, 2026
2 tasks
@mwargan
Copy link
Contributor Author

mwargan commented Feb 8, 2026

Added it to two more components missing it

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@apps/v4/registry/new-york-v4/ui/popover/PopoverContent.vue`:
- Line 37: In PopoverContent.vue locate the long className string used for the
popover container (the token containing
origin-(--reka-popover-content-transform-origin) and outline-hidden,) and remove
the stray comma after outline-hidden so classes remain space-separated (match
the working pattern in DropdownMenuSubContent.vue); ensure there's a single
space between outline-hidden and the following
max-w-(--reka-popper-available-width) token so Tailwind can apply both classes
correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant