Skip to content

fix(onboarding): restore page refresh on Go to Dashboard #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elibosley merged 10 commits into from
Mar 27, 2026
Merged

fix(onboarding): restore page refresh on Go to Dashboard #1967

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5991f6d
fix(onboarding): restore page refresh on "Go to Dashboard" completion
Ajit-Mehrotra Mar 26, 2026
abad07f
test(onboarding): update test to match reload-on-complete behavior
Ajit-Mehrotra Mar 26, 2026
4a5e39f
refactor(onboarding): always reload on completion, simplify handleAct…
Ajit-Mehrotra Mar 26, 2026
e745533
fix(onboarding): reload on all modal close paths including X button a…
Ajit-Mehrotra Mar 26, 2026
e618434
refactor(onboarding): simplify closeModal by removing dead branches
Ajit-Mehrotra Mar 26, 2026
e1db4be
refactor(onboarding): remove handleActivationSkip wrapper
Ajit-Mehrotra Mar 26, 2026
ee245d4
refactor(onboarding): remove redundant onComplete override for ACTIVA…
Ajit-Mehrotra Mar 26, 2026
0379a96
Merge branch 'main' into fix/onboarding-dashboard-refresh
elibosley Mar 27, 2026
a5c9ae7
fix(onboarding): wrap closeModal in try/finally for resilient cleanup
Ajit-Mehrotra Mar 27, 2026
6737f27
fix(onboarding): remove undefined isProgrammaticHistoryExit reference
Ajit-Mehrotra Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions web/src/components/Onboarding/OnboardingModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,14 @@ const docsButtons = computed<BrandButtonProps[]>(() => {
});

const closeModal = async (options?: { reload?: boolean }) => {
if (options?.reload) {
await onboardingModalStore.closeModal();
cleanupOnboardingStorage();
clearHistorySession();
window.location.reload();
return;
}

if (typeof window !== 'undefined' && isManualSession.value && historyPosition.value >= 0) {
window.history.go(-(historyPosition.value + 1));
return;
Expand All @@ -312,10 +320,6 @@ const closeModal = async (options?: { reload?: boolean }) => {
await onboardingModalStore.closeModal();
cleanupOnboardingStorage();
clearHistorySession();

if (options?.reload) {
window.location.reload();
}
};

const setActiveStepByIndex = (stepIndex: number) => {
Expand Down Expand Up @@ -607,7 +611,7 @@ const currentStepProps = computed<Record<string, unknown>>(() => {
case 'NEXT_STEPS':
return {
...baseProps,
onComplete: () => closeModal({ reload: !isManualSession.value }),
onComplete: () => closeModal({ reload: true }),
};

default:
Expand Down
Loading