Skip to content

fix: check mdState to determine array stopped during onboarding #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elibosley merged 3 commits into from
Mar 27, 2026
+23 −1
Merged

fix: check mdState to determine array stopped during onboarding #1969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e38cdb5
feat: onboarding use history
elibosley Mar 25, 2026
4b26ae0
Merge remote-tracking branch 'origin/main' into feat/onboarding-use-h…
elibosley Mar 27, 2026
8236be8
fix: check mdState instead of fsState to determine if array is stopped
elibosley Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions api/src/unraid-api/graph/resolvers/servers/server.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ describe('ServerService', () => {
vi.mocked(getters.emhttp).mockReturnValue({
var: {
name: 'Tower',
mdState: 'STARTED',
fsState: 'Started',
},
} as any);
Expand All @@ -99,6 +100,24 @@ describe('ServerService', () => {
});
});

it('allows name change when mdState is STOPPED even if fsState is not Stopped (internal boot)', async () => {
vi.mocked(getters.emhttp).mockReturnValue({
var: {
name: 'Tower',
mdState: 'STOPPED',
fsState: 'Started',
regGuid: 'GUID-123',
port: '80',
comment: '',
},
networks: [{ ipaddr: ['192.168.1.10'] }],
} as unknown as ReturnType<typeof getters.emhttp>);

await expect(service.updateServerIdentity('NewTower', 'desc')).resolves.toMatchObject({
name: 'NewTower',
});
});

it('calls emcmd with expected params and returns optimistic server', async () => {
const result = await service.updateServerIdentity('Tower', 'Primary host');

Expand Down
5 changes: 4 additions & 1 deletion api/src/unraid-api/graph/resolvers/servers/server.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { GraphQLError } from 'graphql';

import { emcmd } from '@app/core/utils/clients/emcmd.js';
import { getters } from '@app/store/index.js';
import { ArrayState } from '@app/unraid-api/graph/resolvers/array/array.model.js';
import {
ProfileModel,
Server,
Expand Down Expand Up @@ -100,8 +101,10 @@ export class ServerService {
}

if (name !== currentName) {
const mdState = currentEmhttp.var?.mdState;
const fsState = currentEmhttp.var?.fsState;
if (fsState !== 'Stopped') {
const arrayStopped = mdState === ArrayState.STOPPED || fsState === 'Stopped';
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate rename on mdState before fsState fallback

The new arrayStopped check uses mdState === STOPPED || fsState === 'Stopped', which means a stale fsState value can still allow renaming even when mdState indicates the array is running. Since this change makes mdState the primary signal, fsState should only be consulted when mdState is unavailable; otherwise the guard can be bypassed in mixed-state conditions and the mutation may permit name changes while the array is effectively started.

Useful? React with 👍 / 👎.

if (!arrayStopped) {
throw new GraphQLError('The array must be stopped to change the server name.');
}
}
Expand Down
Loading