Skip to content

fix(onboarding): hide boot pool info alert when storage boot is unavailable #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ajit-Mehrotra wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix(onboarding): hide boot pool info alert when storage boot is unavailable #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/__test__/components/Onboarding/OnboardingInternalBootStep.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ describe('OnboardingInternalBootStep', () => {
await flushPromises();

expect(wrapper.find('[data-testid="internal-boot-eligibility-panel"]').exists()).toBe(true);
expect(wrapper.find('[data-testid="internal-boot-intro-panel"]').exists()).toBe(true);
expect(wrapper.find('[data-testid="internal-boot-intro-panel"]').exists()).toBe(false);
expect(wrapper.text()).not.toContain('No eligible devices were detected for internal boot setup.');
await wrapper.get('[data-testid="internal-boot-eligibility-toggle"]').trigger('click');
await flushPromises();
Expand Down
4 changes: 2 additions & 2 deletions web/src/components/Onboarding/steps/OnboardingInternalBootStep.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ const primaryButtonText = computed(() => t('onboarding.internalBootStep.actions.
/>

<UAlert
v-if="isStorageBootSelected && hasEligibleDevices && isDedicatedMode"
v-if="isStorageBootSelected && canConfigure && isDedicatedMode"
data-testid="internal-boot-intro-panel"
class="my-8"
color="neutral"
Expand All @@ -822,7 +822,7 @@ const primaryButtonText = computed(() => t('onboarding.internalBootStep.actions.
</UAlert>

<UAlert
v-if="isStorageBootSelected && hasEligibleDevices && !isDedicatedMode"
v-if="isStorageBootSelected && canConfigure && !isDedicatedMode"
data-testid="internal-boot-intro-panel"
class="my-8"
color="neutral"
Expand Down
Loading