Skip to content

Commit 32613b3

Browse files
committed
chore: hold SimpleBase at 5.6.2 pending upstream encoder fix
1 parent 913b71e commit 32613b3

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

src/Base58Encoding.Tests/SimpleBaseFuzzTests.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,9 @@ namespace Base58Encoding.Tests;
1111
// to run just one (e.g. -method "*Bitcoin_32And64*").
1212
//
1313
// Ground truth is a BigInteger oracle (the literal definition of Base58), so the fuzz validates our
14-
// code without trusting any third party. We also cross-check our ENCODER against SimpleBase's, but
15-
// intentionally do NOT assert SimpleBase.Decode(ours): SimpleBase's decoder (5.6.0 and 5.6.2) drops
16-
// the most-significant byte on some larger inputs (verified: our encoding matches the oracle and the
17-
// Python base58 library, both of which decode it correctly). Reported: ssg/SimpleBase#83
18-
// (https://github.com/ssg/SimpleBase/issues/83).
14+
// code without trusting any third party. We also cross-check our encoder against SimpleBase's, but
15+
// not SimpleBase.Decode(ours): its 5.6.2 decoder drops the most-significant byte on some lengths
16+
// (ssg/SimpleBase#83, fixed in 5.6.3 — which we cannot take yet, see Directory.Packages.props).
1917
public class SimpleBaseFuzzTests
2018
{
2119
private const string Alphabet = "123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz";

src/Directory.Packages.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<ItemGroup>
66
<PackageVersion Include="BenchmarkDotNet" Version="0.15.8" />
77
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.1.0" />
8+
<!-- Held at 5.6.2: 5.6.3's encoder truncates at 128-char output (ssg/SimpleBase#87). -->
89
<PackageVersion Include="SimpleBase" Version="5.6.2" />
910
<PackageVersion Include="System.Numerics.Tensors" Version="10.0.10" />
1011
<PackageVersion Include="xunit.v3.mtp-v2" Version="3.2.2" />

0 commit comments

Comments
 (0)