fix: add memory-aware num_proc default in standardize_data_formats#404
fix: add memory-aware num_proc default in standardize_data_formats#404yurekami wants to merge 1 commit intounslothai:mainfrom
Conversation
Previously, standardize_data_formats defaulted to using all CPU cores (cpu_count()) when num_proc was not specified. This could exhaust memory when processing large datasets, as each worker imports heavy dependencies. The fix adds memory-aware defaults: - Limits workers based on available memory (assume ~1GB per worker) - Falls back to 1 worker when memory is below 4GB - Matches the safer approach used in train_on_responses_only Fixes unslothai#87 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @yurekami, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial enhancement to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a memory-aware default for num_proc in standardize_data_formats to prevent out-of-memory errors when processing large datasets. This is a significant improvement over the previous approach of defaulting to all available CPU cores. The new logic is more robust and considers available system memory to determine a safe number of worker processes. My review includes a few suggestions to further enhance code quality and maintainability, such as using isinstance for type checking, avoiding bare except clauses for better error handling, and ensuring consistency in calculations. Overall, this is a well-thought-out and valuable fix.
| except: | ||
| pass |
There was a problem hiding this comment.
Using a bare except: is a dangerous practice as it catches all exceptions, including system-exiting ones like SystemExit and KeyboardInterrupt, which can hide critical issues and make debugging difficult. It's better to catch a more specific exception, such as Exception.
| except: | |
| pass | |
| except Exception: | |
| pass |
| num_proc = cpu_count() | ||
| import psutil | ||
|
|
||
| if num_proc is None or type(num_proc) is not int: |
There was a problem hiding this comment.
| # Use a memory-aware default to prevent OOM with large datasets | ||
| num_proc = min(max(psutil.cpu_count()+4, 2), 64) | ||
| try: | ||
| memory_gb_left = psutil.virtual_memory().available / 1024 / 1024 / 1024 |
There was a problem hiding this comment.
For consistency with other parts of the codebase (e.g., the train_on_responses_only function) and for improved readability, it's better to use (1024**3) for converting bytes to gigabytes.
| memory_gb_left = psutil.virtual_memory().available / 1024 / 1024 / 1024 | |
| memory_gb_left = psutil.virtual_memory().available / (1024**3) |
Summary
Previously,
standardize_data_formats()defaulted to using all CPU cores (cpu_count()) whennum_procwas not specified. This could exhaust memory when processing large datasets, as each worker imports heavy dependencies like PyArrow.The fix adds memory-aware defaults:
min(max(psutil.cpu_count()+4, 2), 64)train_on_responses_onlyRelated Issue
Fixes #87
Test plan
🤖 Generated with Claude Code