fix: pass system_type argument to do_we_need_sudo()

[yurekami]

Summary

• Fixed missing system_type argument being passed to do_we_need_sudo() function in install_llama_cpp()
• The system_type variable was already available from check_build_requirements() but wasn't being passed to the function

Problem

On Fedora/RHEL and other RPM-based systems, the do_we_need_sudo() function needs the system_type parameter to determine which package manager to use (yum/dnf vs apt-get). Without this argument, the function defaults to Debian-style commands which fail on non-Debian systems.

Changes

• unsloth_zoo/llama_cpp.py: Pass system_type to do_we_need_sudo() call

Fixes #390

🤖 Generated with Claude Code

[gemini-code-assist]

Summary of Changes

Hello @yurekami, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request rectifies a critical bug in the Llama.cpp installation process that prevented successful execution on certain Linux distributions. By correctly passing the system_type argument to the do_we_need_sudo function, the system can now accurately identify the appropriate package manager for sudo operations, thereby improving the robustness and compatibility of installations across diverse operating environments, particularly RPM-based systems.

Highlights

• Bug Fix: Resolved an issue where the system_type argument was not being passed to the do_we_need_sudo() function within install_llama_cpp().
• System Compatibility: This fix addresses installation failures on RPM-based systems (like Fedora/RHEL) by ensuring the correct package manager (yum/dnf instead of apt-get) is used when determining sudo requirements.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug where the system_type was not being passed to the do_we_need_sudo() function. This caused issues on RPM-based systems like Fedora/RHEL, as the function would default to using Debian-specific package manager commands. The fix correctly passes the system_type variable, which is already available, ensuring the right commands are used based on the detected Linux distribution. The change is correct and effectively resolves the reported issue.

[danielhanchen]

Closing as superseded by #405, which includes the same change to pass system_type into do_we_need_sudo in llama_cpp.py.