fix: use importlib for dynamic module imports in patch_compiling_bitsandbytes#410
fix: use importlib for dynamic module imports in patch_compiling_bitsandbytes#410yurekami wants to merge 1 commit intounslothai:mainfrom
Conversation
…andbytes Replace exec/eval pattern with importlib.import_module() to fix 'peft' not being defined error. The previous approach using exec() with globals()/locals() didn't properly persist imports in the execution context. Changes: - Add importlib import at top of file - Use importlib.import_module() for dynamic imports - Use getattr() instead of eval() for attribute access - Add try/except to gracefully handle missing optional dependencies Fixes unslothai#311 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @yurekami, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the robustness of dynamic module imports within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly improves the dynamic module import mechanism in patch_compiling_bitsandbytes by replacing the problematic exec()/eval() pattern with importlib.import_module() and getattr(). This change enhances code security, readability, and robustness, and correctly handles optional dependencies like peft by catching ImportError. The overall change is excellent. I've added one minor suggestion to improve the exception handling further.
| for fx in layers: | ||
| try: layer = eval(f"{x}.{fx}") | ||
| try: layer = getattr(module, fx) | ||
| except: continue |
There was a problem hiding this comment.
While this is an existing issue, it's good practice to avoid bare except: clauses. They can catch unexpected exceptions like SystemExit or KeyboardInterrupt, making it harder to debug or stop the program. It's better to catch a more specific exception, or Exception at the very least.
| except: continue | |
| except Exception: continue |
Summary
'peft' is not definederror inpatch_compiling_bitsandbytes()functionexec()/eval()pattern with properimportlib.import_module()Problem
The previous code used
exec(f"import {x}", globals(), locals())followed byeval(x)to dynamically import modules. This pattern doesn't reliably persist imports in the execution context, causingNameError: name 'peft' is not definederrors.Changes
import importlibat top of fileimportlib.import_module(x)for dynamic importsgetattr(module, fx)instead ofeval(f"{x}.{fx}")Fixes #311
🤖 Generated with Claude Code