Skip to content

fix: use importlib for dynamic module imports in patch_compiling_bitsandbytes#410

Open
yurekami wants to merge 1 commit intounslothai:mainfrom
yurekami:fix-311-peft-import-patching-utils
Open

fix: use importlib for dynamic module imports in patch_compiling_bitsandbytes#410
yurekami wants to merge 1 commit intounslothai:mainfrom
yurekami:fix-311-peft-import-patching-utils

Conversation

@yurekami
Copy link
Contributor

Summary

  • Fixed 'peft' is not defined error in patch_compiling_bitsandbytes() function
  • Replaced problematic exec()/eval() pattern with proper importlib.import_module()

Problem

The previous code used exec(f"import {x}", globals(), locals()) followed by eval(x) to dynamically import modules. This pattern doesn't reliably persist imports in the execution context, causing NameError: name 'peft' is not defined errors.

Changes

  • Added import importlib at top of file
  • Use importlib.import_module(x) for dynamic imports
  • Use getattr(module, fx) instead of eval(f"{x}.{fx}")
  • Added try/except to gracefully skip optional dependencies (peft) if not installed

Fixes #311

🤖 Generated with Claude Code

…andbytes

Replace exec/eval pattern with importlib.import_module() to fix 'peft'
not being defined error. The previous approach using exec() with
globals()/locals() didn't properly persist imports in the execution
context.

Changes:
- Add importlib import at top of file
- Use importlib.import_module() for dynamic imports
- Use getattr() instead of eval() for attribute access
- Add try/except to gracefully handle missing optional dependencies

Fixes unslothai#311

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yurekami, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the robustness of dynamic module imports within the patch_compiling_bitsandbytes function. By replacing an unreliable exec()/eval() pattern with importlib.import_module(), it resolves a NameError related to undefined modules and ensures that optional dependencies are handled gracefully, preventing crashes when certain libraries are not present.

Highlights

  • Resolved NameError: The patch_compiling_bitsandbytes() function no longer throws NameError: name 'peft' is not defined.
  • Refactored Dynamic Imports: The problematic exec()/eval() pattern for dynamic module loading has been replaced with the more robust importlib.import_module().
  • Improved Attribute Access: Switched from eval(f"{x}.{fx}") to getattr(module, fx) for safer and clearer attribute retrieval within dynamically loaded modules.
  • Graceful Dependency Handling: Added try/except ImportError blocks to allow the function to gracefully skip optional dependencies like peft if they are not installed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the dynamic module import mechanism in patch_compiling_bitsandbytes by replacing the problematic exec()/eval() pattern with importlib.import_module() and getattr(). This change enhances code security, readability, and robustness, and correctly handles optional dependencies like peft by catching ImportError. The overall change is excellent. I've added one minor suggestion to improve the exception handling further.

for fx in layers:
try: layer = eval(f"{x}.{fx}")
try: layer = getattr(module, fx)
except: continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this is an existing issue, it's good practice to avoid bare except: clauses. They can catch unexpected exceptions like SystemExit or KeyboardInterrupt, making it harder to debug or stop the program. It's better to catch a more specific exception, or Exception at the very least.

Suggested change
except: continue
except Exception: continue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'peft' is not defined in patching_utils.py

1 participant

Comments