Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Gemma3 Vision + Gemma3N audio inference on transformers 5.x #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Fix Gemma3 Vision + Gemma3N audio inference on transformers 5.x #492
Changes from all commits
cbe7aac9da41f0File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was effecting gpt_oss
That is why I had to do this conversion
Once this lands, can we explore removing that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wrapper now calls
lazy_initializationwith both key and value tensors, but in transformers 4.x (StaticLayer/StaticSlidingWindowLayer) the method only acceptskey_states; withUNSLOTH_FORCE_FLOAT32=1, the first cache update raisesTypeErrorbefore inference can proceed on static-cache paths. Because this patch has no version/arity guard, it introduces a runtime regression for 4.x users (the same issue is repeated inpatched_sw_update).Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic within
patched_updateandpatched_sw_updateis identical. To improve maintainability and reduce code duplication, you can extract the common logic into a helper function. This will make the code cleaner and easier to manage in the future.