feat(non-github scm): Initial sounding-out of non-github SCM support#48
Closed
AmandaCameron wants to merge 3 commits intoupdatecli:mainfrom
Closed
feat(non-github scm): Initial sounding-out of non-github SCM support#48AmandaCameron wants to merge 3 commits intoupdatecli:mainfrom
AmandaCameron wants to merge 3 commits intoupdatecli:mainfrom
Conversation
Member
|
Hey @AmandaCameron, Sorry for the late reply, busy week and I wanted to have some time to formalize what I have in mind. I was considering moving each scm configuration to one scm partial file per scm kind. For example: _scm.github.yaml_scm.gitea.yamlI think it would be easier to maintain and will require less yaml code for policies containing multiple manifest |
Member
|
Here is an example of a test policy leveraging the partial feature |
Member
|
Closing in favor of #49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example alternate solution to updatecli/updatecli#5461
Description
This PR is an example of how I think we could easily make non-github SCMs work for this repo.
Test
To use this on, for example, codeberg.org:
Additional Information
Tradeoff
This makes the configuration somewhat more complex for non-github users, but it doesn't break existing github users. ( At least, it shouldn't, unless I missed something)
Potential improvement
This should allow any SCM to be used that is supported by updatecli, without a bunch of if-else's for different SCMs