Merged
Conversation
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
There was a problem hiding this comment.
Pull request overview
This PR updates frontend dependencies and refactors the SCM dashboard experience, including persisting SCM filter/collapse UI state in browser storage and modernizing ESLint configuration.
Changes:
- Migrate ESLint setup to flat config (
eslint.config.js), update Vue CLI webpack lint integration, and bump related dev dependencies. - Refactor SCM dashboard view routing/UI (remove
SCMDashboard.vue, move SCM dashboard layout intoDashboard.vue, and enhance SCM summary UI with collapse/expand + branch paging). - Persist SCM filter state and SCM summary collapse state via
localStorage.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| vue.config.js | Reworks devServer proxy formatting and replaces Vue CLI’s default eslint plugin wiring with a custom eslint-webpack-plugin setup for flat config. |
| src/views/SCMDashboard.vue | Removes the legacy SCM dashboard view component. |
| src/views/Dashboard.vue | Replaces prior dashboard content with the SCM dashboard layout (filter + summary + loading overlay). |
| src/router/index.js | Re-points SCM routes to the updated Dashboard.vue view. |
| src/components/scm/_summary.vue | Adds repo collapse/expand controls, “load more branches” per repo, revised pagination/loading flow, and persists collapse state. |
| src/components/scm/_scmDoughnut.vue | Simplifies doughnut component by removing internal options mutation. |
| src/components/scm/_filter.vue | Improves date-range display, adds “Now” auto-refresh behavior, and persists filter state. |
| src/components/pipeline/report.vue | Simplifies error handling by removing unused catch binding. |
| src/App.vue | Removes the hardcoded nav links, leaving routing to dedicated navigation components. |
| package.json | Updates dependencies/devDependencies; replaces Vue CLI lint script with ESLint CLI usage. |
| package-lock.json | Updates lockfile to reflect dependency bumps. |
| eslint.config.js | Introduces ESLint flat config for Vue + JS with browser/node globals. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test
/
Additional Information
Tradeoff
Potential improvement