Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR makes minor adjustments to the CI and dependency setup to update the workflows.
- Updates the fallback prop type in the ConditionalSuspense component for broader compatibility.
- Modifies the dependency version specification for "@uploadcare/file-uploader" in package.json.
- Upgrades the Node version and changes the install command in the CI workflow.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react-uploader/src/SSR/ConditionalSuspense/ConditionalSuspense.tsx | Updates fallback type to React.ReactNode for enhanced compatibility. |
| packages/react-uploader/package.json | Removes caret notation for fixed version dependency. |
| .github/workflows/checks.yml | Updates Node version to 20 and changes install command from npm ci to npm i. |
Comments suppressed due to low confidence (1)
.github/workflows/checks.yml:19
- Using 'npm i' in a CI environment may lead to non-deterministic builds compared to 'npm ci'. Consider reverting to 'npm ci' to ensure reproducibility and faster installations.
run: npm i
nd0ut
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist