-
Notifications
You must be signed in to change notification settings - Fork 28
Rewrite public API docs and verified examples for gem-rewrite-3 #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vipulnsward
wants to merge
48
commits into
main
Choose a base branch
from
gem-rewrite-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 38 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
6b7f9ed
Finalize v5 rewrite API and tests
vipulnsward 9821a80
Fix cname cache scoping and tighten error handling
vipulnsward f22d44b
Address code review feedback on examples and resources
vipulnsward d496ae8
Adopt compact class syntax and qualify constants
vipulnsward 6d51789
Update README title and remove outdated compatibility note
vipulnsward b36e40a
Trim README API reference section
vipulnsward ecbba8c
Address CodeRabbit review findings
vipulnsward 376ad59
Harden file metadata paths and add coverage
vipulnsward 8ff7ce6
Replace pending integration specs and satisfy rubocop
vipulnsward 7dacd6b
Speed up multipart retry specs
vipulnsward 3492470
Avoid regex stripping in Akamai HMAC key
vipulnsward 1d9b3ea
Fix README API examples and headings
vipulnsward 8194f31
Address review feedback on auth, conversion, and UUID handling
vipulnsward 0d9dd47
Add specs for result and webhook behaviors
vipulnsward 911aca0
Cover upload file info and conversion result handling
vipulnsward 0ece524
Make result error message expectation Ruby-version agnostic
vipulnsward 102144c
Redact uploadcare keys in VCR fixtures
vipulnsward c4da96e
Use HMAC-SHA256 for upload signature generation
vipulnsward 34f014e
Exclude authenticator from Snyk code scan
vipulnsward 576bafc
Adjust Snyk policy exclusions
vipulnsward 3abc2e9
Fix review feedback, improve multi-account config, and harden VCR scr…
vipulnsward cd3ea32
Fix RuboCop offenses in VCR scrubber and parallel upload
vipulnsward ab77d89
Avoid hardcoded secrets in multi-account spec
vipulnsward 5d9b19e
Scrub Authorization values in VCR fixtures
vipulnsward eb4538b
Fix verified README/examples flows and group/file metadata issues
vipulnsward b08811b
Fix result handling and multipart upload regressions
vipulnsward b73e840
Rewrite gem architecture per blueprint
vipulnsward 357494b
Thorough multipart upload specs and fix Zeitwerk exception autoloading
vipulnsward 80d7985
Tighten client boundaries and normalize upload IO
vipulnsward 4c39848
Fix resource client resolution defaults
vipulnsward 5de71c4
Tighten upload validation and conversion accessors
vipulnsward 986fea0
Refresh API examples for endpoint coverage
vipulnsward bc6fea3
Refresh README and workflow examples
vipulnsward 409ab7b
Clean up YARD attribute declarations
vipulnsward 5f179d7
Refresh migration docs and remove rewrite blueprint
vipulnsward 407521f
Fix CI test command and example script linting
vipulnsward 705f204
Scope CI style checks to changed Ruby files
vipulnsward 26ae82a
Run RuboCop across the full library surface
vipulnsward 507054d
Fix review issues across client and CI
vipulnsward cf7c47a
Exclude bundled gems from RuboCop
vipulnsward d0c2986
Fix remaining RuboCop CI failures
vipulnsward 432b0b8
Update Snyk exclusion for rewritten authenticator
vipulnsward bd3c3d7
Tighten legacy REST auth digest handling
vipulnsward ac09448
Fix standalone example loading and execution
vipulnsward 83fbc3d
Resolve remaining review cleanups
vipulnsward 3e1d35f
Fix remaining review follow-ups
vipulnsward efb689c
Tighten examples and pagination helpers
vipulnsward 726cac2
Refine authenticator digest lookup
vipulnsward File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Uploadcare API credentials | ||
| # Copy this file to .env and fill in your actual keys | ||
| # Get your keys from: https://app.uploadcare.com/projects/-/api-keys/ | ||
|
|
||
| UPLOADCARE_PUBLIC_KEY=your_public_key_here | ||
| UPLOADCARE_SECRET_KEY=your_secret_key_here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| --- | ||
| exclude: | ||
| code: | ||
| - lib/uploadcare/authenticator.rb |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.