DOCS-1156: Update README with subdomain examples (uploadcare-swift)#136
DOCS-1156: Update README with subdomain examples (uploadcare-swift)#136IvanTechnicalWriter wants to merge 3 commits intouploadcare:masterfrom
Conversation
WalkthroughDocumentation-only change: README’s Swift “Example of uploads” snippet updated the example URL from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
124-127: Fix sample: metadata set on undeclared variable.Line 125 references fileForUploading2 before it’s declared; intent seems to set metadata on fileForUploading1.
- fileForUploading2.metadata = ["myKey": "myValue"] + fileForUploading1.metadata = ["myKey": "myValue"]
🧹 Nitpick comments (1)
README.md (1)
128-133: Remove unused variable to avoid confusion.fileForUploading2 is declared (Line 130) but never used. Either demonstrate using it or drop the line.
- var fileForUploading2 = uploadcare.file(withContentsOf: url)!
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build and test on latest Ubuntu (5.6.3)
- GitHub Check: Build and test on latest Ubuntu (5.1)
Co-authored-by: Aleksandr Grenishin <nd0ut.me@gmail.com>
|
Reopened internally as PR #137. Closing this fork PR. |
2 participants
Summary:
Switch generic CDN example in README from ucarecdn.com to demo.ucarecd.net
Changes:
• README.md – updated one example URL only
Notes:
• Badges, logos, and images left untouched (live assets)
• README-only change
Resolves: DOCS-1156
Note:
CI failures are due to fork PRs running without API keys (Public key not found). Safe to merge once approved; alternatively I can reopen from an internal branch when write access is granted.
Summary by CodeRabbit