Adding support for ERC 1271#33
Open
Muhammad-Altabba wants to merge 6 commits intouport-project:developfrom
Open
Adding support for ERC 1271#33Muhammad-Altabba wants to merge 6 commits intouport-project:developfrom
Muhammad-Altabba wants to merge 6 commits intouport-project:developfrom
Conversation
added 6 commits
September 8, 2020 11:40
- Upgrade solidity code to v0.5.16 and its breaking changes - Update test cases code for the breaking changes of web3 v1.2.1
- Test the methods that accepts the composed signature that is signed by a private key
- And add ERC1271 Sample contract
andresobandoalfaro
left a comment
There was a problem hiding this comment.
Great Contribution I downloaded the code and test it deploying the contracts in a private network, and it worked pretty smoothly, the tests provided in test/ethereum_did_registry.js has also great value.
|
hello @mirceanis , as @andresobandoalfaro pointed out this code worked really well for us. You way want to consider merging it in. Thank you!! |
andresobandoalfaro
approved these changes
Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull is to add support for ERC 1271 and it includes:
checkSignature' and other methods overloading toEthereumDIDRegistryto make it compatible withERC1271`EthereumDIDRegistry