Merged
Conversation
check upstash/ratelimit-js#149 for more details
alitariksahin
approved these changes
Feb 5, 2026
There was a problem hiding this comment.
Pull request overview
This PR migrates the npm publishing process from token-based authentication to OpenID Connect (OIDC) authentication, following the approach demonstrated in upstash/ratelimit-js#149. It also restructures the CI/CD workflows by introducing a central ci.yml workflow that orchestrates tests and releases, and includes a test fix for hybrid index querying.
Changes:
- Migrated npm publishing to use OIDC with the
--provenanceflag instead of explicit NPM_TOKEN credentials - Restructured GitHub Actions workflows with a new
ci.ymlorchestrator that callstests.yamlandrelease.yamlas reusable workflows - Updated GitHub Actions to newer versions (checkout@v4, setup-node@v4) and fixed deprecated
set-outputsyntax
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
New orchestrator workflow that triggers tests and release workflows based on event type with OIDC permissions |
.github/workflows/tests.yaml |
Converted to reusable workflow (workflow_call), moved env vars to job level, updated actions, and changed Node version to 24 |
.github/workflows/release.yaml |
Converted to reusable workflow with prerelease input, removed NPM_TOKEN step, added OIDC setup with registry-url and --provenance |
src/commands/client/query/query-single/index.test.ts |
Added missing awaitUntilIndexed call before querying hybrid index with embedding to prevent race conditions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check upstash/ratelimit-js#149 for more details