refactor:Count、Limit、Offsetuse int64 param#1348
Open
CyJaySong wants to merge 1 commit intouptrace:masterfrom
Open
refactor:Count、Limit、Offsetuse int64 param#1348CyJaySong wants to merge 1 commit intouptrace:masterfrom
Count、Limit、Offsetuse int64 param#1348CyJaySong wants to merge 1 commit intouptrace:masterfrom
Conversation
6d33c0d to
3f3481d
Compare
|
This fixes my problem. I replaced the vendor version of the package with the corrected one and there were no problems. I am currently using stubs: func (r *BunRepo) throwInt32(j int) error {
if j < 0 || j > 2000000000 {
// int and int32 limit: 2147483647
return fmt.Errorf("the Count method returns numbers outside the allowed range. It is recommended to correct the return value to the int64 type: %v", j)
}
return nil
}
func (r *BunRepo) throwInt64(j int64) error {
if j < 0 || j > 2000000000 {
// int and int32 limit: 2147483647
return fmt.Errorf("the Count method returns numbers outside the allowed range. It is recommended to correct the return value to the int64 type: %v", j)
}
return nil
}. When the Pull Request is accepted, I will install the new version without this problem. |
|
@CyJaySong Thank you for your work. We also need to correct the commit message. Otherwise, the commitlint stage ends with an error. |
Author
Count、Limit、Offsetuse int64 param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #1323