Skip to content

refactor:CountLimitOffsetuse int64 param#1348

Open
CyJaySong wants to merge 1 commit intouptrace:masterfrom
CyJaySong:fix-1323
Open

refactor:CountLimitOffsetuse int64 param#1348
CyJaySong wants to merge 1 commit intouptrace:masterfrom
CyJaySong:fix-1323

Conversation

@CyJaySong
Copy link

for #1323

@CyJaySong CyJaySong changed the title boom: Count、Limit、Offset use int64 param refactor: Count、Limit、Offset use int64 param Mar 18, 2026
@CyJaySong CyJaySong force-pushed the fix-1323 branch 5 times, most recently from 6d33c0d to 3f3481d Compare March 19, 2026 02:05
@cvaize
Copy link

cvaize commented Mar 19, 2026

This fixes my problem. I replaced the vendor version of the package with the corrected one and there were no problems.

I am currently using stubs:

func (r *BunRepo) throwInt32(j int) error {
	if j < 0 || j > 2000000000 {
		// int and int32 limit: 2147483647
		return fmt.Errorf("the Count method returns numbers outside the allowed range. It is recommended to correct the return value to the int64 type: %v", j)
	}

	return nil
}

func (r *BunRepo) throwInt64(j int64) error {
	if j < 0 || j > 2000000000 {
		// int and int32 limit: 2147483647
		return fmt.Errorf("the Count method returns numbers outside the allowed range. It is recommended to correct the return value to the int64 type: %v", j)
	}

	return nil
}

.

When the Pull Request is accepted, I will install the new version without this problem.

@cvaize
Copy link

cvaize commented Mar 19, 2026

@CyJaySong Thank you for your work. We also need to correct the commit message. Otherwise, the commitlint stage ends with an error.

@CyJaySong
Copy link
Author

@vmihailenco

@CyJaySong CyJaySong changed the title refactor: Count、Limit、Offset use int64 param refactor:CountLimitOffsetuse int64 param Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants