Skip to content

Call actions on flags set from env #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dearchap merged 1 commit into from
Nov 9, 2025
Merged

Call actions on flags set from env #2221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions command_run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,9 +207,14 @@ func (cmd *Command) run(ctx context.Context, osArgs []string) (_ context.Context
}

for _, flag := range cmd.allFlags() {
isSet := flag.IsSet()
if err := flag.PostParse(); err != nil {
return ctx, err
}
// add env set flags here
if !isSet && flag.IsSet() {
cmd.setFlags[flag] = struct{}{}
}
}

if cmd.After != nil && !cmd.Root().shellCompletion {
Expand Down
22 changes: 22 additions & 0 deletions flag_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1727,6 +1727,28 @@ func TestParseGenericFromEnv(t *testing.T) {
assert.NoError(t, cmd.Run(buildTestContext(t), []string{"run"}))
}

func TestFlagActionFromEnv(t *testing.T) {
t.Setenv("X", "42")
x := 0

cmd := &Command{
Flags: []Flag{
&IntFlag{
Name: "x",
Sources: EnvVars("X"),
Action: func(ctx context.Context, cmd *Command, v int) error {
x = v
return nil
},
},
},
}

assert.NoError(t, cmd.Run(buildTestContext(t), []string{"run"}))
assert.Equal(t, cmd.Int("x"), 42)
assert.Equal(t, x, 42)
}

func TestParseMultiString(t *testing.T) {
_ = (&Command{
Flags: []Flag{
Expand Down