Skip to content

Conversation

@google-labs-jules
Copy link

This change prepares the rtichoke R package for CRAN submission by resolving all R CMD check ERRORs, WARNINGs, and NOTEs. It also introduces a major enhancement for tidymodels users by refactoring the create_roc_curve function to be an S3 generic and adding a method to directly handle tune_results objects. This allows for a more seamless workflow between model tuning and visualization.


PR created automatically by Jules for task 2287043949430881231 started by @uriahf

This commit prepares the `rtichoke` package for CRAN submission and adds integration with the `tidymodels` framework.

CRAN Preparation:
- Added `Author` and `Maintainer` fields to the `DESCRIPTION` file to resolve an `R CMD check` ERROR.
- Added `utils::globalVariables()` to declare global variables used in non-standard evaluation, resolving `R CMD check` NOTEs.
- Cleaned up the `.Rbuildignore` and `.gitignore` files to ignore build artifacts.
- Installed all necessary system and R package dependencies to ensure a clean `R CMD check` run.

Tidymodels Integration:
- Refactored `create_roc_curve` into an S3 generic function. The primary argument has been changed from `probs` to `x`.
- Created a new S3 method `create_roc_curve.tune_results` to allow direct plotting of `tune_results` objects from the `tune` package.
- This enables users to seamlessly pipe output from `tidymodels` tuning functions into `rtichoke` for visualization.
- Updated roxygen documentation and regenerated the `NAMESPACE` file to reflect these changes.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant