273 small changes for better calibration plots #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `polars.qcut` function was found to produce inconsistently sorted string-based intervals across different versions of the `polars` library. This caused incorrect ordering of deciles in the calibration curve plot. This commit replaces the `qcut` implementation with a more robust, manual calculation using the `rank()` window function. The new logic, `((rank - 1) * n_bins // N) + 1`, correctly and consistently assigns items to their respective deciles, ensuring the calibration curve is plotted correctly regardless of the `polars` version.
…8663597 Fix: Replace unstable `qcut` with robust rank-based decile calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.