fix(ipc): Handle unsuccessful setup for monitor environment #357
+214
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for urunc canceled.
|
ananos
approved these changes
Dec 18, 2025
In case there was an error during the monitor execution environment setup (e.g. vmm not found, rootfs issue) then the urunc start command was keep waiting for a message from reexec that everything was ok. This was leading to the urunc start process hanging there forever and of course the container was staying like that. THis commit fixes this issue and moreover it slightly refactors the whole IPC between the urunc instances and reexec. PR: #357 Signed-off-by: Charalampos Mainas <[email protected]> Reviewed-by: Anastassios Nanos <[email protected]> Approved-by: Anastassios Nanos <[email protected]>
github-actions
bot
force-pushed
the
fix_ipc
branch
from
239588d to
1da5133
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there was an error during the monitor execution environment setup (e.g. vmm not found, rootfs issue) then the urunc start command was keep waiting for a message from reexec that everything was ok. This was leading to the urunc start process hanging there forever and of course the container was staying like that.
THis commit fixes this issue and moreover it slightly refactors the whole IPC between the urunc instances and reexec.