Move e2e image pulling to setup phase

.github/contributors.yaml

@@ -41,3 +41,6 @@ users:
   KhitemMed:
     name: Medfouni Khitem
     email: lk_medfouni@esi.dz
+  IrvingMg:
+    name: Irving Mondragón
+    email: mirvingr@gmail.com

.github/linters/urunc-dict.txt

@@ -299,6 +299,7 @@ sirupsen
 socker
 stretchr
 strictatime
+subtest
 superfences
 sworker
 symfollow

tests/e2e/common.go

@@ -30,8 +30,6 @@ type testTool interface {
 	getContainerID() string
 	setPodID(string)
 	setContainerID(string)
-	pullImage() error
-	rmImage() error
 	createPod() (string, error)
 	createContainer() (string, error)
 	startContainer(bool) (string, error)

tests/e2e/crictl.go

@@ -157,30 +157,6 @@ func (i *crictlInfo) setContainerID(cID string) {
 	i.containerID = cID
 }
 
-func (i *crictlInfo) pullImage() error {
-	cmdBase := crictlName
-	cmdBase += " pull "
-	cmdBase += i.testArgs.Image
-	output, err := commonCmdExec(cmdBase)
-	if err != nil {
-		return fmt.Errorf("Pull: %s -- %v", output, err)
-	}
-
-	return nil
-}
-
-func (i *crictlInfo) rmImage() error {
-	cmdBase := crictlName
-	cmdBase += " rmi "
-	cmdBase += i.testArgs.Image
-	output, err := commonCmdExec(cmdBase)
-	if err != nil {
-		return fmt.Errorf("Remove image: %s -- %v", output, err)
-	}
-
-	return nil
-}
-
 func (i *crictlInfo) createPod() (string, error) {
 	cwd, err := os.Getwd()
 	if err != nil {

tests/e2e/ctr.go

@@ -84,14 +84,6 @@ func (i *ctrInfo) setContainerID(cID string) {
 	i.containerID = cID
 }
 
-func (i *ctrInfo) pullImage() error {
-	return commonPull(ctrName, i.testArgs.Image)
-}
-
-func (i *ctrInfo) rmImage() error {
-	return commonRmImage(ctrName, i.testArgs.Image)
-}
-
 func (i *ctrInfo) createPod() (string, error) {
 	// Not supported by ctr
 	return "", errToolDoesNotSupport

tests/e2e/docker.go

@@ -57,14 +57,6 @@ func (i *dockerInfo) setContainerID(cID string) {
 	i.containerID = cID
 }
 
-func (i *dockerInfo) pullImage() error {
-	return commonPull(dockerName, i.testArgs.Image)
-}
-
-func (i *dockerInfo) rmImage() error {
-	return commonRmImage(dockerName, i.testArgs.Image)
-}
-
 func (i *dockerInfo) createPod() (string, error) {
 	// Not supported by docker
 	return "", errToolDoesNotSupport