test(e2e): add retry logic for image pulling #377
Conversation
👷 Deploy Preview for urunc processing.
|
✅ Deploy Preview for urunc canceled.
|
codesmith25103
force-pushed
the
Issue376
branch
from
3839d39 to
30a4a30
Compare
cmainas
left a comment
cmainas
left a comment
There was a problem hiding this comment.
Thank you @codesmith25103 for this change, I have added a few comments, but most importantly, I think we can improve the changes by simply creating a new function that handles the retry logic instead of changing the pullImageForTest function.
tests/e2e/setup_test.go
Outdated
| var err error | ||
| maxRetries := 5 | ||
|
|
||
| for i := 0; i < maxRetries; i++ { |
There was a problem hiding this comment.
I think we can improve the doe here, by simply creating a new function which implements the retry logic and calling pullImageForTest and hence we do not have to change pullImageForTest
There was a problem hiding this comment.
Hi @cmainas, I’ve implemented a new function with retry support (PullImageWithRetry) which wraps pullImageForTest. Should I update the codebase to call PullImageWithRetry wherever pullImageForTest is currently used?
There was a problem hiding this comment.
Yes, we should replace pullImageForTest
Currently, end-to-end tests fail intermittently during the setup phase due to image pulling failures (e.g., registry timeouts or network issues). This commit adds a retry mechanism with exponential backoff to the image pulling logic in the test setup. It attempts to pull the required images up to 5 times before failing the test. Signed-off-by: Sankalp <[email protected]>
codesmith25103
force-pushed
the
Issue376
branch
from
81c0898 to
37647cb
Compare
2 participants
test(e2e): add retry logic for image pulling
Currently, end-to-end tests fail intermittently during the setup phase
due to image pulling failures (e.g., registry timeouts or network
issues).
This commit adds a retry mechanism with exponential backoff to the
image pulling logic in the test setup. It attempts to pull the required
images up to 5 times before failing the test.
Fixes: #376