fix(mount): apply chmod to correct destination path#456
Merged
cmainas merged 1 commit intourunc-dev:main-pr456from Feb 12, 2026
Merged
fix(mount): apply chmod to correct destination path#456cmainas merged 1 commit intourunc-dev:main-pr456from
cmainas merged 1 commit intourunc-dev:main-pr456from
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Hello @AyushSriv06 , this PR looks good, but before merging, please add yourself here https://github.com/urunc-dev/urunc/blob/main/.github/contributors.yaml for our CI. |
4 tasks
Contributor
Author
|
Hello @cmainas, can this branch get merged? |
Contributor
|
Hello @AyushSriv06 , thae changes look good, but a small rebase, just to be on the safe side, would be necessary. |
Signed-off-by: Ayush <ayushsrisks@gmail.com>
AyushSriv06
force-pushed
the
fix/mount-logic
branch
from
b99107a to
d72e3f0
Compare
cmainas
approved these changes
Feb 12, 2026
Contributor
cmainas
left a comment
cmainas
left a comment
There was a problem hiding this comment.
Thank you @AyushSriv06 for the fix.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
PR: #456 Signed-off-by: Ayush <ayushsrisks@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
PR: #456 Signed-off-by: Ayush <ayushsrisks@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in pkg/unikontainers/mount.go where
os.Chmodwas being called on the path variable instead of the resolveddstPath.Related issues
N/A
How was this tested?
lint and build
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).