Skip to content

Build supported nginx versions only #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ jobs:
- id: supported-nginx-versions
name: Generate nginx
shell: bash
run: | # The "1.17-nginx1-nginx" in here will be changed to "1.17 nginx1 nginx" when calling ./build-http.sh
echo "::set-output name=versions::[\"1.17-nginx1-nginx\", \"1.16\", \"1.15\", \"1.14\"]"
run: | # The "1.19-nginx1-nginx" in here will be changed to "1.19 nginx1 nginx" when calling ./build-http.sh
echo "::set-output name=versions::[\"1.19-nginx1-nginx\", \"1.18\"]"
supported-php-versions:
name: Supported PHP versions
runs-on: ubuntu-latest
Expand Down
8 changes: 3 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,14 @@ build-fpm: clean-tags
# Docker HTTP images build matrix ./build-nginx.sh (nginx version) (extra tag)
build-http: BUILDINGIMAGE=http
build-http: clean-tags
./build-http.sh 1.17 nginx1 nginx
./build-http.sh 1.16
./build-http.sh 1.15
./build-http.sh 1.14
./build-http.sh 1.19 nginx1 nginx
./build-http.sh 1.18

# Docker Prometheus Exporter file images build matrix ./build-prometheus-exporter-file.sh (nginx version) (extra tag)
# Adding arbitrary version 1.0 in order to make sure if we break compatibility we have to up it
build-prometheus-exporter-file: BUILDINGIMAGE=prometheus-exporter-file
build-prometheus-exporter-file: clean-tags
./build-prometheus-exporter-file.sh 1.15 prometheus-exporter-file1.0 prometheus-exporter-file1
./build-prometheus-exporter-file.sh 1.18 prometheus-exporter-file1.0 prometheus-exporter-file1

.NOTPARALLEL: clean-tags
clean-tags:
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/test_nginx_entrypoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def test_nginx_sigterm_handling(host, container):

logs = host.run('docker logs {}'.format(container))

assert u'signal 15 (SIGTERM) received, exiting' in logs.stderr
assert u'signal 3 (SIGQUIT) received, shutting down' in logs.stderr
assert u'exit' in logs.stderr


Expand Down