added exit button in the tour #2125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatilHarshh
commented
Jul 20, 2025
PatilHarshh
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Parvinmh @binrysearch please review |
binrysearch
requested changes
Jul 27, 2025
| @@ -217,6 +218,25 @@ const NextButton = ({ | |||
| return nextButton; | |||
| }; | |||
|
|
|||
| const ExitButton = ({ | |||
There was a problem hiding this comment.
The cross (X) button in the header already provides the functionality to exit the tour. Could you please help me understand why we need a separate button for this?
From the UX point of view, adding more buttons to the footer of the dialog is not needed given that the X button already provides the same functionality.
I'm still happy to provide a way for users to customise the dialog though. That way, you can add/remove buttons to the dialog in your application when constructing the Intro.js Tour. This might require a bit of work on our side but then allows users to have fully customisable dialogs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.