BREAKING CHANGE: remove py2 support#12
Open
jochman wants to merge 1 commit intousagitoneko97:masterfrom
Open
Conversation
Author
|
@usagitoneko97 Hey, what's up? |
Author
|
@usagitoneko97 alive mate? |
|
Hi @jochman, Would it possible to keep the python dependency at python 3.6 and still use the standard ast library? We should handled gracefully the fact that type annotations from comments are not available in python 3.6 and 3.7. Also there are many more code to cleanup while dropping support for python2. Maybe this can be done later, though. Are you willing to fork this library and continue maintaining it? I would be down to add support for imports and define a higher level api interface. If you want we can create an organization to host a new repository for klara. Tell me what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've removed typed-ast package at there are problems with this package in apple-silicon.
Also, typed ast recommends using the builtin ast module from python 3.8 and up.
I could not understand why the uts are failing, I would like to get help to fix those.