convenient known vs. observed inspector#255
Conversation
buffer=clip limit + convenient known vs. observed inspector
|
Decided to simply remove the |
buffer=clip limit + convenient known vs. observed inspector|
@martinfleis – I'd like to get this curated since it makes finding trouble makers much easier if high-level checks are passing (which they weren't even doing that with the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
=======================================
- Coverage 99.1% 98.8% -0.2%
=======================================
Files 7 7
Lines 1274 1274
=======================================
- Hits 1262 1259 -3
- Misses 12 15 +3 🚀 New features to boost your workflow:
|
|
@martinfleis Unless you have strong feelings against this I am going to proceed with merge. If you do have strong feelings against, I'd like to hear them and we can discuss (because this inspection method in this PR has been very helpful for debugging/comparing differences). |
This PR:
sees wherebuffer=clip limitgets us when callingvoronoi_skeleton()within:artifacts.multiple_remaining()artifacts.one_remaining_c()buffer=clip_limitfor smoother angles? #254conftest.pyif highest-level checks pass and only fordev.ci_artifacts.zip
Even if we need to remove the1, the second bullet point is worth keeping for sure.buffer=clip limitportion from this PRFootnotes
After reviewing the CI artifacts via the checker notebook it seems these
buffer=clip limitchanges lead to sharper angles, so we should probably leave as is. ↩