Skip to content

convenient known vs. observed inspector#255

Merged
jGaboardi merged 6 commits intomainfrom
notebook_viz_for_checking
Dec 16, 2025
Merged

convenient known vs. observed inspector#255
jGaboardi merged 6 commits intomainfrom
notebook_viz_for_checking

Conversation

@jGaboardi
Copy link
Collaborator

@jGaboardi jGaboardi commented Jul 2, 2025

This PR:

  • sees where buffer=clip limit gets us when calling voronoi_skeleton() within:
  • provides a convenient known vs. observed inspection notebook where we can easily
    • display the full PNG with diffs in red
    • see the known vs. observed discrepancies tabular data
    • explore the known vs. observed discrepancies
    • known vs. observed discrepancies are curated here in conftest.py if highest-level checks pass and only for dev.
    • attached here is some example data – Doula only

ci_artifacts.zip


Even if we need to remove the buffer=clip limit portion from this PR1, the second bullet point is worth keeping for sure.

Footnotes

  1. After reviewing the CI artifacts via the checker notebook it seems these buffer=clip limit changes lead to sharper angles, so we should probably leave as is.

@jGaboardi jGaboardi changed the title buffer=clip limt - #254 + easy known vs. observerd try buffer=clip limit + convenient known vs. observed inspector Jul 2, 2025
@jGaboardi
Copy link
Collaborator Author

jGaboardi commented Dec 14, 2025

I am going to break this PR into 2 parts:

1. Keep "try buffer=clip limit" part here (and probably close later)
2. Open a fresh PR for the "convenient known vs. observed inspector" portion, which is super handy

Decided to simply remove the buffer=clip limit stuff from the PR since it's a dead-end

@jGaboardi jGaboardi changed the title try buffer=clip limit + convenient known vs. observed inspector convenient known vs. observed inspector Dec 15, 2025
@jGaboardi
Copy link
Collaborator Author

@martinfleis – I'd like to get this curated since it makes finding trouble makers much easier if high-level checks are passing (which they weren't even doing that with the pandas>=3 issues from yesterday)

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.8%. Comparing base (b7421ac) to head (78919c4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #255     +/-   ##
=======================================
- Coverage   99.1%   98.8%   -0.2%     
=======================================
  Files          7       7             
  Lines       1274    1274             
=======================================
- Hits        1262    1259      -3     
- Misses        12      15      +3     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi
Copy link
Collaborator Author

@martinfleis Unless you have strong feelings against this I am going to proceed with merge. If you do have strong feelings against, I'd like to hear them and we can discuss (because this inspection method in this PR has been very helpful for debugging/comparing differences).

@jGaboardi jGaboardi merged commit 41b548c into main Dec 16, 2025
13 checks passed
@jGaboardi jGaboardi deleted the notebook_viz_for_checking branch December 16, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments