COMPAT: compatibility with pandas 3

[martinfleis]

This resolves #281 . Pandas 3 copy-on-write logic has bitten us here.

cc @anastassiavybornova as this was your piece of code. Something to avoid in future.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.8%. Comparing base (ac48821) to head (8ec7df0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #283     +/-   ##
=======================================
- Coverage   99.1%   98.8%   -0.2%     
=======================================
  Files          7       7             
  Lines       1275    1274      -1     
=======================================
- Hits        1263    1259      -4     
- Misses        12      15      +3     

Files with missing lines	Coverage Δ
neatnet/artifacts.py	98.3% <100.0%> (-<0.1%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jGaboardi]

@martinfleis – great find!

Another approach could be in L355 to do:

is_artifact = polys["is_artifact"].copy()

That would also solve to problem, correct? Or no?

[martinfleis]

Unlikely. We are changing the values of the column in the loop below so making the copy beforehand does not update the reference.