Skip to content

ENH: return same object as is given in close_gaps and extend_lines#286

Merged
jGaboardi merged 3 commits intomainfrom
data-type-consistencyt
Dec 15, 2025
Merged

ENH: return same object as is given in close_gaps and extend_lines#286
jGaboardi merged 3 commits intomainfrom
data-type-consistencyt

Conversation

@martinfleis
Copy link
Contributor

Resolves pysal/momepy#723

Technically a breaking change but here we are at 0.1 and in momepy we are deprecating it, so I'd say it is fine?

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.8%. Comparing base (b7421ac) to head (5b58a57).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #286     +/-   ##
=======================================
- Coverage   99.1%   98.8%   -0.2%     
=======================================
  Files          7       7             
  Lines       1274    1282      +8     
=======================================
+ Hits        1262    1267      +5     
- Misses        12      15      +3     
Files with missing lines Coverage Δ
neatnet/gaps.py 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi jGaboardi added the enhancement New feature or request label Dec 15, 2025
@jGaboardi
Copy link
Collaborator

so I'd say it is fine?

Agreed, it's fine.

@jGaboardi jGaboardi merged commit 62ead41 into main Dec 15, 2025
13 checks passed
@jGaboardi jGaboardi deleted the data-type-consistencyt branch December 15, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconcistency between mm.close_gaps and mm.extend_lines

2 participants

Comments