fix: 🐛 trials_used not properly bypassing cache

[SirTenzin]

---

Summary by cubic

Fixes trials_used to always read from the database and bypass cached customer data. Also tightens the trial matching to avoid false positives.

• Bug Fixes
  • Fetch trials via customerProductRepo.fetchFreeTrials with joins on customerProducts, products, and customers; filters by org, env, and non-null trial_ends_at; returns { plan_id, customer_id, fingerprint } from live data.
  • Match trials by customers.internal_id, and only use fingerprint when present to prevent unintended matches.
  • getCusTrialsUsed delegates to the repo and is called in Promise.all within getApiCustomerExpand; removed the stale in-memory mapping.

^{Written for commit bba2b03. Summary will update on new commits.}

Greptile Summary

This PR successfully addresses the cache bypass issue for trials_used by extracting the logic into a separate async function that queries the database directly, rather than relying on potentially stale cached data in the fullCus object.

Key changes:

• Bug fixes: Extracted getCusTrialsUsed into separate file that performs direct DB query instead of reading from cached fullCus.trials_used
• Improvements: Now called in Promise.all alongside other async expand operations for better performance

The refactor aligns with the pattern used by other expand functions (getCusRewards, getCusReferrals) and ensures trials_used data is always fresh from the database.

Confidence Score: 3/5

• This PR has a logical issue that could cause incorrect query results in edge cases
• The refactor successfully addresses the cache bypass issue, but there's a logic bug in the null ID handling (line 47) that could match unintended customers when fullCus.id is null. The fix is straightforward but critical for correctness.
• Pay close attention to server/src/internal/customers/cusUtils/cusResponseUtils/getCusTrialsUsed.ts for the null ID handling bug

Important Files Changed

Filename	Overview
server/src/internal/customers/cusUtils/apiCusUtils/getApiCustomerExpand.ts	Refactored to use extracted async function for trials_used, removing inline synchronous function
server/src/internal/customers/cusUtils/cusResponseUtils/getCusTrialsUsed.ts	New async function that queries DB directly but has potential issue with null ID handling

_{Last reviewed commit: 0e3e241}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
autumn-vite	Ready	Preview, Comment	Mar 3, 2026 10:15am

[cubic-dev-ai]

No issues found across 2 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

[greptile-apps]

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

if fullCus.id is null/undefined (allowed by schema), this becomes eq(customers.id, "") which could match customers with empty string IDs

Suggested change

	eq(customers.id, fullCus.id ?? ""),
	fullCus.id ? eq(customers.id, fullCus.id) : undefined,

Prompt To Fix With AI

This is a comment left during a code review.
Path: server/src/internal/customers/cusUtils/cusResponseUtils/getCusTrialsUsed.ts
Line: 47

Comment:
if `fullCus.id` is null/undefined (allowed by schema), this becomes `eq(customers.id, "")` which could match customers with empty string IDs

```suggestion
					fullCus.id ? eq(customers.id, fullCus.id) : undefined,
```

How can I resolve this? If you propose a fix, please make it concise.