Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0892d19541
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
shared/api/billing/common/billingParamsBase/billingParamsBaseV1.ts
Outdated
Show resolved
Hide resolved
shared/api/billing/common/billingParamsBase/billingParamsBaseV1.ts
Outdated
Show resolved
Hide resolved
johnyeocx
reviewed
Mar 2, 2026
server/src/internal/billing/v2/actions/attach/errors/handleCarryOverBalancesErrors.ts
Outdated
Show resolved
Hide resolved
server/src/internal/billing/v2/utils/handleCarryOvers/cusProductToExistingBalanceCarryOvers.ts
Outdated
Show resolved
Hide resolved
server/src/internal/billing/v2/utils/handleCarryOvers/cusProductToExistingBalanceCarryOvers.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: John Yeo <51376134+johnyeocx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds carry-over of unused consumable balances on immediate plan upgrades (attach V2) by creating loose entitlements and inserting matching customer entitlements. Supports feature-level filtering and per-entity balances; scheduled switches and non-consumable features are blocked.
New Features
Validation
Written for commit 1bfebfb. Summary will update on new commits.
Greptile Summary
Added schema definitions for carry over balances feature, enabling balance transfers when customers change plans.
Key Changes:
carry_over_balancesconfiguration field toBillingParamsBaseV1Schemawithenabledflag and optionalfeature_idsarray for feature-level granularityinsertCustomerEntitlementsfield toAutumnBillingPlanSchemato support creating customer entitlements during plan operationsCustomerEntitlementSchemato support the new insertCustomerEntitlements fieldThese schema changes lay the groundwork for implementing balance carryover functionality, allowing customers to retain their feature balances when switching between plans.
Confidence Score: 5/5
Important Files Changed
carry_over_balancesfield to enable balance carryover with feature-level granularityinsertCustomerEntitlementsfield to support inserting customer entitlements during plan operationsLast reviewed commit: 363c183