Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Include packages/ksuid/package.json in the Docker build so the ksuid workspace is installed and layer caching works. Fixes Docker builds failing when ksuid is required.
Written for commit 3ffa4eb. Summary will update on new commits.
Greptile Summary
This PR adds the new
packages/ksuidworkspace package to the Dockerfile so itspackage.jsonis copied during the dependency-install layer, consistent with how all other workspace packages are handled in the monorepo build.Key Changes:
docker/Dockerfile: AddsCOPY packages/ksuid/package.json ./packages/ksuid/package.jsonto the pre-install layer, ensuring the new zero-dependency@autumn/ksuidpackage is included in thebun installstep and Docker layer caching works correctly for the full workspace.Confidence Score: 5/5
packages/ksuid) exists in the repo, has no external dependencies, and the copy order is correct relative tobun install.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["FROM oven/bun:1.3.2"] --> B["COPY root package.json + bun.lock"] B --> C["COPY all workspace package.json files\n(server, shared, vite, scripts, apps/checkout,\npackages/autumn-js, packages/openapi,\npackages/ksuid ✅ NEW,\npackages/sdk, apps/sdk-test, apps/docs)"] C --> D["RUN bun install --ignore-scripts\n(cached layer — invalidated only when a package.json changes)"] D --> E["COPY . .\n(full source)"] E --> F["WORKDIR /app/server\nCMD bun start"]Last reviewed commit: 3ffa4eb