src: only commit stickydisk in post step if in setup-only#111
Merged
adityamaru merged 1 commit intomasterfrom Apr 29, 2025
Merged
src: only commit stickydisk in post step if in setup-only#111adityamaru merged 1 commit intomasterfrom
adityamaru merged 1 commit intomasterfrom
Conversation
Firstly this was a bug where we were trying to commit in the post step even if we had already committed at the end of the main step in a non-setup-only invocation. Secondly, if the action is canceled before the exposeID is set in the main process, we don't want to send a commit request with an empty exposeID.
aayushshah15
approved these changes
Apr 29, 2025
aayushshah15
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly this was a bug where we were trying to commit in the post step even if we had already committed at the end of the main step in a non-setup-only invocation.
Secondly, if the action is canceled before the exposeID is set in the main process, we don't want to send a commit request with an empty exposeID.