fix: use correct platform when creating remote buildx builder#118
Merged
adityamaru merged 3 commits intomasterfrom Jun 11, 2025
Merged
fix: use correct platform when creating remote buildx builder#118adityamaru merged 3 commits intomasterfrom
adityamaru merged 3 commits intomasterfrom
Conversation
The remote builder was hardcoded to use --platform linux/amd64 regardless of user input or runner architecture. This caused performance issues on ARM runners and cache inefficiencies. Now properly uses the platforms input or detects host architecture to avoid unnecessary QEMU emulation and improve build performance. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
The test was hardcoded to expect arm64 platform, causing failures on AMD runners. Now checks actual host architecture dynamically. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
adityamaru
force-pushed
the
builder-misconfig
branch
from
f4dbb48 to
616bee0
Compare
aayushshah15
requested changes
Jun 11, 2025
adityamaru
force-pushed
the
builder-misconfig
branch
from
1668ef1 to
51bef8c
Compare
aayushshah15
approved these changes
Jun 11, 2025
aayushshah15
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remote builder was hardcoded to use --platform linux/amd64 regardless of user input or runner architecture. This caused performance issues on ARM runners and cache inefficiencies.
Now properly uses the platforms input or detects host architecture to avoid unnecessary QEMU emulation and improve build performance.
🤖 Generated with Claude Code