Skip to content

in calc_sum added needs.values() as parameter to filter_single_need() #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PhilipPartsch wants to merge 4 commits into
base: master
Choose a base branch
from
Open

in calc_sum added needs.values() as parameter to filter_single_need() #1453

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4485fa
in calc_sum added needs.values() as parameter to filter_single_need()
PhilipPartsch May 7, 2025
0b9602b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 7, 2025
7f41cba
Merge branch 'master' into calc_sum_fix_1452
PhilipPartsch Nov 8, 2025
00e5338
Merge branch 'master' into calc_sum_fix_1452
PhilipPartsch Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sphinx_needs/functions/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,9 @@ def calc_sum(
for check_need in check_needs:
if filter:
try:
if not filter_single_need(check_need, needs_config, filter):
if not filter_single_need(
check_need, needs_config, filter, needs=needs.values()
):
continue
except ValueError:
pass
Expand Down