Skip to content

refactor: remove adding variable while in env var search view#7157

Open
Pragadesh-45 wants to merge 1 commit intousebruno:mainfrom
Pragadesh-45:feat/add-env-var-search
Open

refactor: remove adding variable while in env var search view#7157
Pragadesh-45 wants to merge 1 commit intousebruno:mainfrom
Pragadesh-45:feat/add-env-var-search

Conversation

@Pragadesh-45
Copy link
Contributor

@Pragadesh-45 Pragadesh-45 commented Feb 16, 2026

Description

This PR implements a refactor to display a simple table structure during search, instead of allowing the creation of variables that are not filtered in the search view, which results in unsaved variables in environments.

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced environment variables table search functionality to filter results more accurately. Empty entries are no longer displayed in search results, showing only variables matching your search query.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

The environment variables table filtering logic is simplified by removing special-case handling that preserved the last empty row when a search query was applied. The filter now strictly matches search terms against variable names and values.

Changes

Cohort / File(s) Summary
Environment Variables Table Filtering
packages/bruno-app/src/components/EnvironmentVariablesTable/index.js
Simplified filtering logic by removing the special-case that preserved empty last rows during search queries, now applying strict name/value matching.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

size/S

Suggested reviewers

  • helloanoop
  • bijin-bruno
  • lohit-bruno

Poem

✨ Empty rows fade away,
Filtering crisp and clean,
Special cases stripped today,
Simplicity reigns supreme! 🎯

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the ability to add variables during environment variable search.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments