Skip to content

Add padding on the links, rather than the <div>#123

Merged
CGoodwin90 merged 3 commits intomainfrom
bulk-deployment-links
Feb 2, 2026
Merged

Add padding on the links, rather than the <div>#123
CGoodwin90 merged 3 commits intomainfrom
bulk-deployment-links

Conversation

@seanhamlin
Copy link
Contributor

@seanhamlin seanhamlin commented Feb 1, 2026

to ensure the entire button is clickable. UX improvement.

Old HTML

<div class="bulk-link bg-blue-400 hover:bg-blue-600 py-1 px-2 mr-10 rounded-sm transition-colors"><a class="text-white" href="/bulkdeployment/XXX-XXX-XXX">BULK</a></div>

New HTML

<a class="px-2 py-1 bg-sky-500 text-white rounded text-sm hover:bg-sky-600 transition-colors whitespace-nowrap mr-10" href="/bulkdeployment/XXX-XXX-XXX">BULK</a>

@seanhamlin seanhamlin requested a review from CGoodwin90 February 1, 2026 21:29
@seanhamlin seanhamlin added the UX label Feb 1, 2026
@mattswann
Copy link
Contributor

@seanhamlin can you add some screenshots?

I'm keen to see before and after this change

@CGoodwin90
Copy link
Collaborator

These Links were legacy code from the discarded v2 iteration of the UI. Updated to use our Badge components for consistency & it interacts with light/dark theming.

2026-02-02_10-35 2026-02-02_10-34

@CGoodwin90
Copy link
Collaborator

Discussed & approved with @mattswann

@CGoodwin90 CGoodwin90 merged commit c89343a into main Feb 2, 2026
1 check passed
@CGoodwin90 CGoodwin90 deleted the bulk-deployment-links branch February 2, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants