Skip to content

Fix: Adds correct environmentSlug #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CGoodwin90 merged 2 commits into from
Feb 4, 2026
Merged

Fix: Adds correct environmentSlug #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6f927e
Fixes environmentSlug passed to usePendingChangesNotification on Envi…
CGoodwin90 Feb 4, 2026
27ea389
Updates Story with changes
CGoodwin90 Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...pp/(routegroups)/(projectroutes)/projects/[projectSlug]/[environmentSlug]/routes/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export default async function Routes(props: {
{queryRef => (
<EnvironmentRoutesPage
projectName={projectSlug}
environmentName={environmentSlug}
queryRef={queryRef as QueryRef<EnvironmentRoutesData>}
/>
)}
Expand Down
2 changes: 1 addition & 1 deletion src/components/pages/environmentRoutes/EnvironmentRoutesPage.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const meta: Meta<typeof EnvironmentRoutesPage> = {
query={environmentWithRoutes}
variables={{ openshiftProjectName: 'project-main' }}
>
{queryRef => <EnvironmentRoutesPage queryRef={queryRef} projectName="test-project" />}
{queryRef => <EnvironmentRoutesPage queryRef={queryRef} projectName="test-project" environmentName="main" />}
</MockPreloadQuery>
),
};
Expand Down
5 changes: 3 additions & 2 deletions src/components/pages/environmentRoutes/EnvironmentRoutesPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ import { RoutesDataTableColumns } from './_components/RoutesDataTableColumns';
import React from "react";


export default function EnvironmentRoutesPage({queryRef, projectName,}: {
export default function EnvironmentRoutesPage({queryRef, projectName, environmentName}: {
queryRef: QueryRef<EnvironmentRoutesData>;
projectName: string;
environmentName: string;
}) {
const [{ results, route_query }, setQuery] = useQueryStates({
results: {
Expand Down Expand Up @@ -48,7 +49,7 @@ export default function EnvironmentRoutesPage({queryRef, projectName,}: {
// Show notification for pending changes
usePendingChangesNotification({
environment: environmentRoutes,
environmentSlug: environmentRoutes.name,
environmentSlug: environmentName,
});

return (
Expand Down