Fix: Updates usePendingChangesNotification hook to fix component re-mount#134
Open
CGoodwin90 wants to merge 1 commit intomainfrom
Open
Fix: Updates usePendingChangesNotification hook to fix component re-mount#134CGoodwin90 wants to merge 1 commit intomainfrom
CGoodwin90 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
usePendingChangesNotificationtoast is cleaned up and remounted whenever dependencies change (prod only), causing the toast to appear to flicker and occasionally not render.This fixes the original logic by splitting the updates and the cleanup across two
useEffecthooks, removing the cleanup flicker from the main hook and having that only run on mount/unmount/navigation in the second hook. This also keeps theNODE_ENVcheck to handle the double mountStrict Modeenforces when running in dev.Can verify the fix here: https://ui.prod-toast-fix.lagoon-beta-ui.test6.amazee.io/projects/drupal-example/drupal-example-master