Fix: Calendar date picker not updating #5415 #5416
Open
+106
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses bug usememos#5415 where the calendar date picker was not updating correctly when a new date was selected. This fix involves: - Updating useDateFilterNavigation to correctly handle displayTime filters, ensuring existing filters are replaced with new selections. - Modifying CalendarCell to make all days interactive, allowing users to select any date in the current month, regardless of whether it has memos. - Passing the selected date to useCalendarMatrix in MonthCalendar to ensure the chosen date is visually highlighted.
…lter This commit re-introduces the "Created at" date picker field in the memo editor. This field allows users to explicitly set the creation date of a new memo. Key changes include: - Reinstating the DateTimeInput component in bound to . - Ensuring localization key is present in to support the UI label. - Correctly initializing from the filter in when a new memo is created, if the field is not already set. - Re-adding the action and its corresponding reducer logic to manage updates to . - Removing the unused import from to fix linting errors. These changes ensure the frontend provides and manages the for memos, which will then be used by the backend's (forthcoming) fix to persist this value on initial memo creation.
giuliohome
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5415 by ensuring the calendar date picker updates correctly and allows selection of any date in the current month.