Skip to content

Fix build GHA #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asherf merged 2 commits into from
May 30, 2025
Merged

Fix build GHA #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7da0cfc
Fix build GHA
asherf May 30, 2025
467c66b
fix output path
asherf May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 11 additions & 26 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,18 @@
# Sample workflow for building and deploying a Next.js site to GitHub Pages
#
# To get started with Next.js see: https://nextjs.org/docs/getting-started
#
name: Deploy Docs site to Pages

on:
# Runs on pushes targeting the default branch
push:
branches: ["main"]

# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:

# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
pull_request: {}
workflow_dispatch: {}
permissions:
contents: read
pages: write
id-token: write

# Allow only one concurrent deployment, skipping runs queued between the run in-progress and latest queued.
# However, do NOT cancel in-progress runs as we want to allow these production deployments to complete.
concurrency:
group: "pages"
cancel-in-progress: false

cancel-in-progress: true
jobs:
# Build job
build:
runs-on: ubuntu-latest
steps:
Expand All @@ -48,7 +35,7 @@ jobs:
with:
node-version: "20"
- name: Install pnpm
uses: pnpm/action-setup@v2
uses: pnpm/action-setup@v4
with:
version: 8
run_install: false
Expand All @@ -66,20 +53,16 @@ jobs:
restore-keys: |
${{ runner.os }}-nextjs-${{ hashFiles('pnpm-lock.yaml') }}-
- name: Install dependencies
run: |
cd docs
pnpm install
run: pnpm install
Copy link

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pnpm install step now runs in the repository root instead of the docs directory. To restore the previous behavior, either add working-directory: docs under this step or reintroduce cd docs before the install command.

Suggested change
run: pnpm install
run: pnpm install
working-directory: docs

Copilot uses AI. Check for mistakes.
- name: Build with Next.js
run: |
cd docs
pnpm run build
run: pnpm run build
Copy link

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pnpm run build step also runs in the root instead of docs. Use working-directory: docs here or add cd docs to ensure the build runs in the correct folder.

Suggested change
run: pnpm run build
run: pnpm run build
working-directory: docs

Copilot uses AI. Check for mistakes.
- name: Upload artifact
uses: actions/upload-pages-artifact@v3
with:
path: ./docs/out

# Deployment job
path: ./out
retention-days: 2
deploy:
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
Expand All @@ -89,3 +72,5 @@ jobs:
- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v4
with:
token: ${{ secrets.GITHUB_TOKEN }}