Telegram Bot API library and sample of a Telegram chat bot #385
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/ |
theg4sh
left a comment
theg4sh
left a comment
There was a problem hiding this comment.
Greet job, but have few comments.
| add_subdirectory(mysql "${CMAKE_BINARY_DIR}/userver/mysql") | ||
| endif() | ||
|
|
||
| if (USERVER_FEATURE_CORE) |
There was a problem hiding this comment.
Looks like this feature should be named as USERVER_FEATURE_TELEGRAM.
| @@ -0,0 +1,12 @@ | |||
| -------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Better to describe api in openapi schema format. This is almost a standard to communicate between services and many code generator tools is supported it.
Have you seen json schema? https://core.telegram.org/schema/json
More details available here: https://core.telegram.org/schema
Anyway, looks like all of request-response could be generated in-fly in build directory.
There was a problem hiding this comment.
wrong place, should be in ../client/ folder
|
|
||
| virtual LogOutRequest LogOut(const RequestOptions& request_options) = 0; | ||
|
|
||
| virtual SendAnimationRequest SendAnimation( |
There was a problem hiding this comment.
Looks like the most of this method does not required at all.
They do the same as public FormRequest<T>(T::Parameters{...}, request_options);
|
|
||
| private: | ||
| template <typename Request> | ||
| Request FormRequest( |
There was a problem hiding this comment.
FormRequest -> CreateRequest
and make it public. You'll got the same result, but less code.
| const components::ComponentConfig& config, | ||
| const components::ComponentContext& context); | ||
|
|
||
| telegram::bot::RequestOptions request_options_; |
There was a problem hiding this comment.
This field could be moved inside of components clients and provided within client.hpp.
It looks statically configurable and may be provided by ComponentConfig or dynamic_config
| }; | ||
|
|
||
| template <typename method> | ||
| class [[nodiscard]] Request { |
There was a problem hiding this comment.
It looks like a real client class client/client.hpp, as it is actually should be.
Anyway, telegram/bot/client is a better place for it.
2 participants
Resolves #227