Skip to content

Abort type-check when dependencies have parse errors. #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Abort type-check when dependencies have parse errors. #849

wants to merge 5 commits into from

Conversation

@toinehartman
Copy link
Member

@toinehartman toinehartman commented Oct 20, 2025 •
edited
Loading

Recovered parse error
Shows 1 cause per disambiguated error tree
afbeelding

Fatal parse error
Shows 1 cause for the file with an error
afbeelding

Closes #832

@toinehartman toinehartman self-assigned this Oct 20, 2025
@toinehartman toinehartman added the bug Something isn't working label Oct 20, 2025
@toinehartman toinehartman marked this pull request as ready for review October 20, 2025 13:05
DavyLandman
DavyLandman requested changes Oct 20, 2025
View reviewed changes
Copy link
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quit small, which is great. I have some questions while reading the source code.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavyLandman DavyLandman DavyLandman requested changes

@rodinaarssen rodinaarssen Awaiting requested review from rodinaarssen

@PieterOlivier PieterOlivier Awaiting requested review from PieterOlivier

Requested changes must be addressed to merge this pull request.

Assignees

@toinehartman toinehartman

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

duplicate parse error reported

2 participants

@toinehartman @DavyLandman