Always use ISourceLocation for Rascal locations#929
Merged
toinehartman merged 5 commits intomainfrom Dec 18, 2025
Merged
Conversation
DavyLandman
approved these changes
Dec 17, 2025
|
DavyLandman
approved these changes
Dec 17, 2025
Merged
rodinaarssen
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mapping from LSP locations (lines 0-based, UTF-16 columns) to and from Rascal locations (lines 1-based, UTF-32 columns) often causes confusion (and comes up during reviews, e.g. here #706 (comment)). This is not at all improved by the reuse of LSP4J's
RangeandPositiontypes for some Rascal locations. This PRISourceLocationfor any kind of Rascal location.Locationsby removing the last references toLSPfrom them, since now, the types speak for themselves.