Infer project root correctly from within target folder #949
+33
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toinehartman
changed the title
|
Member
|
Isn't there also rascal side of this bug? |
DavyLandman
approved these changes
Jan 20, 2026
Member
Author
I believe these changes to LSP should solve #948. I think changes to path config computation in Rascal triggered this. I am wondering why our multi-project test did not catch this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project root for
bird/bird-core/target/classeswas computed asbird/bird-core/target/classes(since it contains a copy ofMETA-INF/RASCAL.MF). This caused path configs to be computed from the wrong root, in turn causing type-checks to fail. An example of this is #948.This PR fixes the root inference algorithm by computing roots until the shortest root path is found.
Closes #948.