Skip to content

Rebase via merge#33

Merged
rsoury merged 4 commits intodevelopfrom
master
Feb 27, 2026
Merged

Rebase via merge#33
rsoury merged 4 commits intodevelopfrom
master

Conversation

@rsoury
Copy link
Copy Markdown
Member

@rsoury rsoury commented Feb 27, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed symbol parameter not being properly supplied to order fetch and cancellation operations
    • Updated order details response with enhanced information structure and improved field naming for clarity

rsoury and others added 4 commits February 26, 2026 21:21
include FetchFees for deposit/withdraw by calling FetchFees grpc with…
Compat with Production stack
@rsoury rsoury merged commit 75310a6 into develop Feb 27, 2026
3 of 4 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 27, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1e3eb6a and c27f6b0.

📒 Files selected for processing (1)
  • src/server.ts

Walkthrough

The code now passes the actual symbol value (instead of undefined) when fetching and cancelling orders. The GetOrderDetails response payload has been restructured with field renames (originalAmount → amount, filledAmount → filled, mode → side) and a new remaining field.

Changes

Cohort / File(s) Summary
Order Handling Fix and Response Restructuring
src/server.ts
Fixed undefined symbol parameter in GetOrderDetails and CancelOrder operations; renamed response fields (originalAmount/filledAmount/mode to amount/filled/side) and added remaining field to GetOrderDetails payload.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Poem

🐰 A symbol once lost in the void,
Now found and no longer destroyed,
Fields renamed with care and with grace,
"amount" and "filled" take their place,
The remaining field hops into space! 🐇

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch master

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants