Conversation
rsoury
approved these changes
Apr 12, 2025
| /// | ||
| /// * `bool` - True if the verification is successful, false otherwise | ||
| pub fn ecdsa_verification(&self, proof: String, signature: String) -> bool { | ||
| let root_hash = hash_eth_message(self.generate_merkle_tree(proof)); |
Member
There was a problem hiding this comment.
For maintainability, this should be done outside of the ecdsa_verification
The name of a function should describe exactly what's happening in the function.
Therefore generating the root hash (ecdsa signature message), should exist outside of the method to verify ecdsa (ecdsa_verification).
Just a note...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.